Skip to content

ref(flags): Refactor LaunchDarkly integration to reusable functions #14369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cmanallen merged 12 commits into from
Dec 2, 2024
Merged

ref(flags): Refactor LaunchDarkly integration to reusable functions #14369

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
c8e8c21
ref(flags): Refactor LaunchDarkly integration to reusable functions
billyvg Nov 19, 2024
ddf814b
split insertToFlagBuffer into 2 functions (insertFlagToScope and inse…
billyvg Nov 19, 2024
4195a8e
only copy flags if buffer is not empty
billyvg Nov 19, 2024
2d48782
ref(flags): Refactor LaunchDarkly integration to reusable functions
billyvg Nov 19, 2024
22e7e16
Add OpenFeature browser integration
cmanallen Nov 15, 2024
c9d3a74
Linting
cmanallen Nov 15, 2024
3dcf07e
Add missing semi-colons
cmanallen Nov 15, 2024
1e1d734
update tests to use `shouldSkipFeatureFlagsTest` and `getLocalTestUrl`
billyvg Nov 19, 2024
06e7fbb
ref; use featureFlags util functions
billyvg Nov 19, 2024
a47d337
export copyFlags/insertFlagToScope
billyvg Nov 19, 2024
afd4f78
add error hook test
billyvg Nov 20, 2024
a292a60
Merge pull request #14326 from getsentry/cmanallen/open-feature-integ…
cmanallen Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
only copy flags if buffer is not empty
  • Loading branch information
@billyvg
billyvg committed Nov 20, 2024
commit 4195a8e8c7e24c240b7e559558991738fb8dbc0e
4 changes: 4 additions & 0 deletions packages/browser/src/utils/featureFlags.ts
View file
Open in desktop
Copy link
Member Author

@billyvg billyvg Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine we'll want to use this in node/server environments as well, would it make sense to move these to core?

Copy link
Member

@chargome chargome Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the handler being used in the LD integration is only available for client-side js, that's why this was moved to the browser. Not sure if this will change for other integrations in the future

Copy link
Member Author

@billyvg billyvg Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing in these util functions are specific to LD integration, it stores flag values to scope. It's possible for a server side implementation to re-use these functions.

Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@ export function copyFlagsFromScopeToEvent(event: Event): Event {
const flagContext = scope.getScopeData().contexts.flags;
const flagBuffer = flagContext ? flagContext.values : [];

if (!flagBuffer.length) {
return event;
}

if (event.contexts === undefined) {
event.contexts = {};
}
Expand Down
Loading