Skip to content

Conversation

mydea
Copy link
Member

@mydea mydea commented Sep 22, 2025

This may flake, so just using any available port instead.

Closes #17716

@mydea mydea self-assigned this Sep 22, 2025
Copy link
Member

@chargome chargome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

cursor[bot]

This comment was marked as outdated.

Copy link
Member

@Lms24 Lms24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx for fixing!

Copy link
Contributor

node-overhead report 🧳

Note: This is a synthetic benchmark with a minimal express app and does not necessarily reflect the real-world performance impact in an application.

Scenario Requests/s % of Baseline Prev. Requests/s Change %
GET Baseline 8,990 - 9,098 -1%
GET With Sentry 1,431 16% 1,377 +4%
GET With Sentry (error only) 6,192 69% 5,959 +4%
POST Baseline 1,231 - 1,184 +4%
POST With Sentry 560 45% 499 +12%
POST With Sentry (error only) 1,078 88% 1,030 +5%
MYSQL Baseline 3,362 - 3,317 +1%
MYSQL With Sentry 451 13% 408 +11%
MYSQL With Sentry (error only) 2,732 81% 2,665 +3%

View base workflow run

@mydea mydea enabled auto-merge (squash) September 22, 2025 12:51
@mydea mydea merged commit 34f3479 into develop Sep 22, 2025
188 checks passed
@mydea mydea deleted the fn/node-integration-test-port branch September 22, 2025 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Flaky CI]: OpenAI Node integration test
4 participants