Skip to content

test(node): Avoid using specific port for node-integration-tests #17729

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 22, 2025
Merged

test(node): Avoid using specific port for node-integration-tests #17729

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b2ef44f
test(node): Avoid using specific port for node-integration-tests
mydea Sep 22, 2025
20505a1
properly await server setup
mydea Sep 22, 2025
8998fab
fix port, oops
mydea Sep 22, 2025
d2b5f2d
actually fix it
mydea Sep 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions dev-packages/node-integration-tests/suites/tracing/anthropic/scenario.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ import Anthropic from '@anthropic-ai/sdk';
import * as Sentry from '@sentry/node';
import express from 'express';

const PORT = 3333;

function startMockAnthropicServer() {
const app = express();
app.use(express.json());
Expand Down Expand Up @@ -50,16 +48,21 @@ function startMockAnthropicServer() {
},
});
});
return app.listen(PORT);

return new Promise(resolve => {
const server = app.listen(0, () => {
resolve(server);
});
});
}

async function run() {
const server = startMockAnthropicServer();
const server = await startMockAnthropicServer();

await Sentry.startSpan({ op: 'function', name: 'main' }, async () => {
const client = new Anthropic({
apiKey: 'mock-api-key',
baseURL: `http://localhost:${PORT}/anthropic`,
baseURL: `http://localhost:${server.address().port}/anthropic`,
});

// First test: basic message completion
Expand Down
12 changes: 7 additions & 5 deletions dev-packages/node-integration-tests/suites/tracing/google-genai/scenario.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@ import { GoogleGenAI } from '@google/genai';
import * as Sentry from '@sentry/node';
import express from 'express';

const PORT = 3333;

function startMockGoogleGenAIServer() {
const app = express();
app.use(express.json());
Expand Down Expand Up @@ -39,16 +37,20 @@ function startMockGoogleGenAIServer() {
});
});

return app.listen(PORT);
return new Promise(resolve => {
const server = app.listen(0, () => {
resolve(server);
});
});
}

async function run() {
const server = startMockGoogleGenAIServer();
const server = await startMockGoogleGenAIServer();

await Sentry.startSpan({ op: 'function', name: 'main' }, async () => {
const client = new GoogleGenAI({
apiKey: 'mock-api-key',
httpOptions: { baseUrl: `http://localhost:${PORT}` },
httpOptions: { baseUrl: `http://localhost:${server.address().port}` },
});

// Test 1: chats.create and sendMessage flow
Expand Down
12 changes: 7 additions & 5 deletions dev-packages/node-integration-tests/suites/tracing/openai/scenario-root-span.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
import express from 'express';
import OpenAI from 'openai';

const PORT = 3333;

function startMockOpenAiServer() {
const app = express();
app.use(express.json());
Expand Down Expand Up @@ -31,14 +29,18 @@ function startMockOpenAiServer() {
},
});
});
return app.listen(PORT);
return new Promise(resolve => {
const server = app.listen(0, () => {
resolve(server);
});
});
}

async function run() {
const server = startMockOpenAiServer();
const server = await startMockOpenAiServer();

const client = new OpenAI({
baseURL: `http://localhost:${PORT}/openai`,
baseURL: `http://localhost:${server.address().port}/openai`,
apiKey: 'mock-api-key',
});

Expand Down