-
-
Notifications
You must be signed in to change notification settings - Fork 1.8k
feat(core): Apply scope attributes to logs #18184
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
85fa63a
feat(core): Apply scope attributes to logs
Lms24 42d6e97
wip
Lms24 1ce315f
adjust after scope attribute changes
Lms24 21ae8a4
add browser integration test
Lms24 5ad4a38
adjust browser integration test
Lms24 c92d866
add node integration test
Lms24 5a0e041
remove accidental code
Lms24 7911a2f
test optimizations
Lms24 230c799
only serilialize primitive scope attributes
Lms24 3e110c1
fallback logic only in log attributes
Lms24 1b8ee6a
unify `attributeValueToTypedAttributeValue` with optional fallback logic
Lms24 09c9ffe
adjust tests
Lms24 697c099
more tests
Lms24 4de37b9
100% coverage <3
Lms24 64b5848
fix tests, adjust jsdoc
Lms24 22a8901
further jsdoc adjustments
Lms24 11bccd6
lint
Lms24 75bff04
use Object.fromEntries instead of reduce
Lms24 7939e3e
of course, lint complains
Lms24 d318828
optimize attribute serilaization
Lms24 ee58b92
size bump
Lms24 438df0f
node integration tests assert on equals, not objectContaining
Lms24 5d052fc
lint
Lms24 b70a546
possibly fix logs integration test for 3.8
Lms24 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
use Object.fromEntries instead of reduce
- Loading branch information
commit 75bff04ff8581d718c62df7c204f4de11478a19e
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.