Skip to content

feat(core): Apply scope attributes to logs #18184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Lms24 merged 24 commits into from
Dec 18, 2025
Merged

feat(core): Apply scope attributes to logs #18184

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit Hold shift + click to select a range
85fa63a
feat(core): Apply scope attributes to logs
Lms24 Nov 12, 2025
42d6e97
wip
Lms24 Nov 13, 2025
1ce315f
adjust after scope attribute changes
Lms24 Nov 17, 2025
21ae8a4
add browser integration test
Lms24 Nov 18, 2025
5ad4a38
adjust browser integration test
Lms24 Nov 18, 2025
c92d866
add node integration test
Lms24 Nov 18, 2025
5a0e041
remove accidental code
Lms24 Nov 21, 2025
7911a2f
test optimizations
Lms24 Dec 12, 2025
230c799
only serilialize primitive scope attributes
Lms24 Dec 16, 2025
3e110c1
fallback logic only in log attributes
Lms24 Dec 16, 2025
1b8ee6a
unify `attributeValueToTypedAttributeValue` with optional fallback logic
Lms24 Dec 16, 2025
09c9ffe
adjust tests
Lms24 Dec 16, 2025
697c099
more tests
Lms24 Dec 16, 2025
4de37b9
100% coverage <3
Lms24 Dec 16, 2025
64b5848
fix tests, adjust jsdoc
Lms24 Dec 16, 2025
22a8901
further jsdoc adjustments
Lms24 Dec 16, 2025
11bccd6
lint
Lms24 Dec 16, 2025
75bff04
use Object.fromEntries instead of reduce
Lms24 Dec 16, 2025
7939e3e
of course, lint complains
Lms24 Dec 16, 2025
d318828
optimize attribute serilaization
Lms24 Dec 17, 2025
ee58b92
size bump
Lms24 Dec 17, 2025
438df0f
node integration tests assert on equals, not objectContaining
Lms24 Dec 17, 2025
5d052fc
lint
Lms24 Dec 17, 2025
b70a546
possibly fix logs integration test for 3.8
Lms24 Dec 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test optimizations
  • Loading branch information
@Lms24
Lms24 committed Dec 18, 2025
commit 7911a2f3833f2a247cbfbe77c9d15b594bc035f3
11 changes: 6 additions & 5 deletions dev-packages/browser-integration-tests/suites/public-api/logger/integration/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
import { expect } from '@playwright/test';
import type { LogEnvelope } from '@sentry/core';
import { sentryTest } from '../../../../utils/fixtures';
import { getFirstSentryEnvelopeRequest, properFullEnvelopeRequestParser } from '../../../../utils/helpers';
import {
getFirstSentryEnvelopeRequest,
properFullEnvelopeRequestParser,
testingCdnBundle,
} from '../../../../utils/helpers';

sentryTest('should capture console object calls', async ({ getLocalTestUrl, page }) => {
const bundle = process.env.PW_BUNDLE || '';
// Only run this for npm package exports
if (bundle.startsWith('bundle') || bundle.startsWith('loader')) {
sentryTest.skip();
}
sentryTest.skip(testingCdnBundle());

const url = await getLocalTestUrl({ testDir: __dirname });

Expand Down
12 changes: 6 additions & 6 deletions dev-packages/browser-integration-tests/suites/public-api/logger/scopeAttributes/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
import { expect } from '@playwright/test';
import type { LogEnvelope } from '@sentry/core';
import { sentryTest } from '../../../../utils/fixtures';
import { getFirstSentryEnvelopeRequest, properFullEnvelopeRequestParser } from '../../../../utils/helpers';
import {
getFirstSentryEnvelopeRequest,
properFullEnvelopeRequestParser,
testingCdnBundle,
} from '../../../../utils/helpers';

sentryTest('captures logs with scope attributes', async ({ getLocalTestUrl, page }) => {
const bundle = process.env.PW_BUNDLE || '';
// Only run this for npm package exports
if (bundle.startsWith('bundle') || bundle.startsWith('loader')) {
sentryTest.skip();
}
sentryTest.skip(testingCdnBundle());

const url = await getLocalTestUrl({ testDir: __dirname });

Expand Down
11 changes: 6 additions & 5 deletions dev-packages/browser-integration-tests/suites/public-api/logger/simple/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
import { expect } from '@playwright/test';
import type { LogEnvelope } from '@sentry/core';
import { sentryTest } from '../../../../utils/fixtures';
import { getFirstSentryEnvelopeRequest, properFullEnvelopeRequestParser } from '../../../../utils/helpers';
import {
getFirstSentryEnvelopeRequest,
properFullEnvelopeRequestParser,
testingCdnBundle,
} from '../../../../utils/helpers';

sentryTest('should capture all logging methods', async ({ getLocalTestUrl, page }) => {
const bundle = process.env.PW_BUNDLE || '';
// Only run this for npm package exports
if (bundle.startsWith('bundle') || bundle.startsWith('loader')) {
sentryTest.skip();
}
sentryTest.skip(testingCdnBundle());

const url = await getLocalTestUrl({ testDir: __dirname });

Expand Down
8 changes: 8 additions & 0 deletions dev-packages/browser-integration-tests/utils/helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,14 @@ export function shouldSkipTracingTest(): boolean {
return bundle != null && !bundle.includes('tracing') && !bundle.includes('esm') && !bundle.includes('cjs');
}

/**
* @returns `true` if we are testing a CDN bundle
*/
export function testingCdnBundle(): boolean {
const bundle = process.env.PW_BUNDLE;
return bundle != null && (bundle.startsWith('bundle') || bundle.startsWith('loader'));
}

/**
* Today we always run feedback tests, but this can be used to guard this if we ever need to.
*/
Expand Down