-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
ref(replay): Extract some functions out from class #6448
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
737adb2
ref(replay): Extract `overwriteRecordDroppedEvent` into fn
mydea a558935
ref(replay): Extract span listeners out
mydea db1ab04
ref(replay): Extract handleGlobalEvent handler out
mydea edd132a
ref(replay): Fix accidental renaming
mydea 391a22c
ref(replay): Extract performanceObserver out
mydea 229bd51
ref(replay): Make some things public
mydea 721e682
ref(replay): Extract addEvent out
mydea d7a3e3a
ref(replay): Extract createPerformanceSpans out
mydea e026241
ref(replay): Extract addMemoryEntry out
mydea 3791c69
doc(replay): Add jsdoc to extracted functions
mydea 37efedb
ref(replay): Only import types for extracted replay functions
mydea efc9525
build(replay): Skip type imports for circular dependency check
mydea 432da15
ref(replay): PR feedback
mydea f7caf64
ref(replay): Extract types into `types.ts`
mydea cf54a67
ref(replay): Make `addMemoryEntry` and `createPerformanceSpans` to sync
mydea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
ref(replay): Make some things public
- Loading branch information
commit 229bd5121a44d056bb82bab264276473db815850
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -24,8 +24,7 @@ function handleHistory(handlerData: HistoryHandlerData): ReplayPerformanceEntry | |
|
|
||
| export function handleHistorySpanListener(replay: ReplayContainer): (handlerData: HistoryHandlerData) => void { | ||
| return (handlerData: HistoryHandlerData) => { | ||
| // @ts-ignore private | ||
| if (!replay._isEnabled) { | ||
| if (!replay.isEnabled()) { | ||
| return; | ||
| } | ||
|
|
||
|
|
@@ -36,8 +35,7 @@ export function handleHistorySpanListener(replay: ReplayContainer): (handlerData | |
| } | ||
|
|
||
| // Need to collect visited URLs | ||
| // @ts-ignore private | ||
| replay._context.urls.push(result.name); | ||
| replay.getContext().urls.push(result.name); | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Similar thing to above with trace/error ids. |
||
| replay.triggerUserActivity(); | ||
|
|
||
| replay.addUpdate(() => { | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.