fix(replay): Ensure rrweb types are properly published #6462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rrweb only exposes `typings/entries/all` in it's package.json, so we need to import from there. For this, we need another patch to ensure the things we need are actually re-exported from there.
Member
|
Can we PR rrewb upstream with this? Seems super useful. |
billyvg
approved these changes
Dec 7, 2022
Member
billyvg
left a comment
billyvg
left a comment
There was a problem hiding this comment.
Is this something to address upstream as well?
Member
Author
|
I opened a PR: rrweb-io/rrweb#1067 but even if it is merged, this will only go into v2! |
Contributor
size-limit report 📦
|
Member
Author
|
Okay nevermind, actually rollup is still stripping the types away in our vendored rrweb 😬 so I guess we'll vendor the necessary types for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rrweb only exposes
typings/entries/allin it's package.json, so we need to import from there. For this, we need another patch to ensure the things we need are actually re-exported from there.