Export recordOptions types
#1067
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mydea
force-pushed
the
fn/export-types
branch
from
102024d to
772aeb9
Compare
mydea
changed the title
eventWithTime and recordOptions typesrecordOptions types
Juice10
approved these changes
Jan 6, 2023
YunFeng0817
approved these changes
Jan 6, 2023
This was referenced Feb 12, 2023
This was referenced Jul 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be very helpful to have
recordingOptionsproperly exported. As of now, this is not part ofentries/all.d.ts, which is generated, and is thus tree shaken away.See getsentry/sentry-javascript#6448
Note to self:
eventWithTimecan be imported from@rrweb/typesin v2.