Skip to content

fix(win): make symbolication and modulefinder independent of the system ANSI code page. #1389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
supervacuus merged 17 commits into from
Oct 1, 2025
Merged

fix(win): make symbolication and modulefinder independent of the system ANSI code page. #1389

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
2d91922
fix(win): make symbolication independent of the system ANSI code page.
supervacuus Sep 24, 2025
38f1fee
allow `NULL` module paths and symbol names.
supervacuus Sep 24, 2025
2f50d93
Merge branch 'master' into fix/remove-apc-dependency-windows-symbolic…
supervacuus Sep 24, 2025
de40603
add an integration test that runs the example from a cyrillic directo…
supervacuus Sep 24, 2025
986d65c
resolve relative paths + clean up subdir
supervacuus Sep 24, 2025
202cf41
remove the assertion that a frame must have a function
supervacuus Sep 24, 2025
1404955
only assert on the frame_package being a file if it exists...
supervacuus Sep 24, 2025
898fe24
isolate package assertions to new test
supervacuus Sep 24, 2025
727fe5b
don't conflate checking any function/package with checking package fi…
supervacuus Sep 24, 2025
1957d2a
also adapt the windows modulefinder to be independent system ACP.
supervacuus Sep 25, 2025
e5dd801
update the CHANGELOG
supervacuus Sep 25, 2025
b99127a
explicitly specify `PSAPI_VERSION` because we only want to link kernel32
supervacuus Oct 1, 2025
0c979d3
check string_from_wstr return values
supervacuus Oct 1, 2025
5f17b73
use a heap-allocated 32K buffer for module paths
supervacuus Oct 1, 2025
d67abba
use a heap-allocated 32K buffer for symbol paths
supervacuus Oct 1, 2025
d30e4cd
move allocation into wrapping if
supervacuus Oct 1, 2025
d67a769
format after webui edit
supervacuus Oct 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
explicitly specify PSAPI_VERSION because we only want to link kernel32
  • Loading branch information
@supervacuus
supervacuus authored Oct 1, 2025
commit b99127a41ea0ddbfc6a951bf62bc62da1ca2a14e
1 change: 1 addition & 0 deletions src/modulefinder/sentry_modulefinder_windows.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
#ifndef SENTRY_PLATFORM_XBOX
# include <dbghelp.h>
#endif
#define PSAPI_VERSION 2
#include <Psapi.h>
#include <TlHelp32.h>

Expand Down
Loading