-
-
Notifications
You must be signed in to change notification settings - Fork 201
fix(win): make symbolication and modulefinder independent of the system ANSI code page. #1389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
supervacuus
merged 17 commits into
master
from
fix/remove-apc-dependency-windows-symbolication
Oct 1, 2025
Merged
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
2d91922
fix(win): make symbolication independent of the system ANSI code page.
supervacuus 38f1fee
allow `NULL` module paths and symbol names.
supervacuus 2f50d93
Merge branch 'master' into fix/remove-apc-dependency-windows-symbolic…
supervacuus de40603
add an integration test that runs the example from a cyrillic directo…
supervacuus 986d65c
resolve relative paths + clean up subdir
supervacuus 202cf41
remove the assertion that a frame must have a function
supervacuus 1404955
only assert on the frame_package being a file if it exists...
supervacuus 898fe24
isolate package assertions to new test
supervacuus 727fe5b
don't conflate checking any function/package with checking package fi…
supervacuus 1957d2a
also adapt the windows modulefinder to be independent system ACP.
supervacuus e5dd801
update the CHANGELOG
supervacuus b99127a
explicitly specify `PSAPI_VERSION` because we only want to link kernel32
supervacuus 0c979d3
check string_from_wstr return values
supervacuus 5f17b73
use a heap-allocated 32K buffer for module paths
supervacuus d67abba
use a heap-allocated 32K buffer for symbol paths
supervacuus d30e4cd
move allocation into wrapping if
supervacuus d67a769
format after webui edit
supervacuus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
use a heap-allocated 32K buffer for symbol paths
- Loading branch information
commit d67abba8cfcd24d563b367ce8100edec61b7ca36
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: String Conversion and Memory Management Issues
The
sentry__string_from_wstrcalls formod_pathandsymbol_nameintroduce two issues. If these conversions fail, the callback receivesNULLpointers forframe_info.object_nameandframe_info.symbol. If successful, the heap-allocated strings are freed immediately, causing use-after-free if the callback stores these pointers. Both can lead to crashes or unexpected behavior.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That is a sensible warning, but intentional in the current code: