-
-
Notifications
You must be signed in to change notification settings - Fork 356
chore(deps): update JavaScript SDK to v10.32.1 #5496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5a0224e to
bd9c48a
Compare
bd9c48a to
15600d5
Compare
15600d5 to
979853b
Compare
…JS SDK update TypeScript's stricter type narrowing in JS SDK v10.32.1 caused compilation errors when accessing properties on plain objects after type guards. Fixed by adding explicit type assertion to Record<string, unknown>.
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ✅
Fixed a build issue with d3b49fc by adding a type assertion to explicitly cast the plain object to Record<string, unknown> before accessing its properties.
After updating to JavaScript SDK v10.32.1, TypeScript's stricter type
narrowing caused compilation errors in the NativeLinkedErrors integration.
The issue occurred when accessing properties on plain objects after a chain
of type guards, where TypeScript inferred the type as 'never'.
Waiting for the CI to go 🟢
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 36841a6+dirty | 502.96 ms | 547.14 ms | 44.18 ms |
| eec00c2+dirty | 447.08 ms | 469.04 ms | 21.96 ms |
| c94a927+dirty | 366.16 ms | 375.68 ms | 9.52 ms |
| ff5a06a+dirty | 405.97 ms | 439.24 ms | 33.27 ms |
| ee69ed5+dirty | 409.44 ms | 441.30 ms | 31.86 ms |
| 2b89ce9 | 413.69 ms | 442.58 ms | 28.89 ms |
| ad27f6e+dirty | 471.44 ms | 516.23 ms | 44.79 ms |
| 083f560+dirty | 358.21 ms | 382.00 ms | 23.79 ms |
| b80b14f+dirty | 505.06 ms | 534.32 ms | 29.26 ms |
| 05bef0e+dirty | 349.78 ms | 334.04 ms | -15.74 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 36841a6+dirty | 43.75 MiB | 48.07 MiB | 4.32 MiB |
| eec00c2+dirty | 43.75 MiB | 48.05 MiB | 4.29 MiB |
| c94a927+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| ff5a06a+dirty | 43.75 MiB | 48.05 MiB | 4.29 MiB |
| ee69ed5+dirty | 43.75 MiB | 48.04 MiB | 4.29 MiB |
| 2b89ce9 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| ad27f6e+dirty | 43.75 MiB | 48.07 MiB | 4.32 MiB |
| 083f560+dirty | 17.75 MiB | 19.70 MiB | 1.96 MiB |
| b80b14f+dirty | 43.75 MiB | 48.04 MiB | 4.29 MiB |
| 05bef0e+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
Previous results on branch: deps/scripts/update-javascript.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 15c429b+dirty | 367.98 ms | 417.98 ms | 50.00 ms |
| dcebdb7+dirty | 382.04 ms | 379.62 ms | -2.42 ms |
| 5275213+dirty | 420.84 ms | 462.24 ms | 41.40 ms |
| 1eed088+dirty | 377.06 ms | 365.22 ms | -11.84 ms |
| 028a929+dirty | 479.78 ms | 475.83 ms | -3.95 ms |
| 3cf1cb0+dirty | 348.30 ms | 364.98 ms | 16.68 ms |
| 91d4b7d | 406.98 ms | 419.14 ms | 12.16 ms |
| b9f1fe4+dirty | 413.76 ms | 405.46 ms | -8.30 ms |
| ae0e9ff+dirty | 385.88 ms | 403.54 ms | 17.66 ms |
| c67d99f+dirty | 465.22 ms | 497.10 ms | 31.88 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 15c429b+dirty | 43.75 MiB | 48.07 MiB | 4.32 MiB |
| dcebdb7+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 5275213+dirty | 43.75 MiB | 48.04 MiB | 4.29 MiB |
| 1eed088+dirty | 17.75 MiB | 19.69 MiB | 1.94 MiB |
| 028a929+dirty | 43.75 MiB | 47.99 MiB | 4.24 MiB |
| 3cf1cb0+dirty | 17.75 MiB | 19.74 MiB | 2.00 MiB |
| 91d4b7d | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| b9f1fe4+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| ae0e9ff+dirty | 17.75 MiB | 19.71 MiB | 1.96 MiB |
| c67d99f+dirty | 43.75 MiB | 48.05 MiB | 4.30 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 46da307+dirty | 356.62 ms | 415.02 ms | 58.40 ms |
| 36841a6+dirty | 404.22 ms | 450.06 ms | 45.84 ms |
| eec00c2+dirty | 367.00 ms | 392.12 ms | 25.12 ms |
| 2104bb9+dirty | 313.00 ms | 309.76 ms | -3.24 ms |
| ff5a06a+dirty | 438.29 ms | 476.00 ms | 37.71 ms |
| ee69ed5+dirty | 411.19 ms | 447.04 ms | 35.85 ms |
| 2adbd1e+dirty | 366.13 ms | 419.49 ms | 53.36 ms |
| ad27f6e+dirty | 484.67 ms | 532.79 ms | 48.12 ms |
| af9331b+dirty | 374.42 ms | 425.68 ms | 51.26 ms |
| b80b14f+dirty | 320.33 ms | 376.06 ms | 55.73 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 46da307+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 36841a6+dirty | 43.94 MiB | 48.90 MiB | 4.96 MiB |
| eec00c2+dirty | 43.94 MiB | 48.87 MiB | 4.93 MiB |
| 2104bb9+dirty | 7.15 MiB | 8.46 MiB | 1.30 MiB |
| ff5a06a+dirty | 43.94 MiB | 48.87 MiB | 4.93 MiB |
| ee69ed5+dirty | 43.94 MiB | 48.87 MiB | 4.93 MiB |
| 2adbd1e+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| ad27f6e+dirty | 43.94 MiB | 48.90 MiB | 4.96 MiB |
| af9331b+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| b80b14f+dirty | 43.94 MiB | 48.87 MiB | 4.93 MiB |
Previous results on branch: deps/scripts/update-javascript.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 15c429b+dirty | 361.38 ms | 385.02 ms | 23.65 ms |
| dcebdb7+dirty | 460.67 ms | 498.36 ms | 37.70 ms |
| 5275213+dirty | 422.28 ms | 445.08 ms | 22.80 ms |
| 1eed088+dirty | 355.56 ms | 384.47 ms | 28.90 ms |
| 028a929+dirty | 385.59 ms | 410.49 ms | 24.90 ms |
| 3cf1cb0+dirty | 348.50 ms | 401.20 ms | 52.70 ms |
| b9f1fe4+dirty | 377.53 ms | 429.20 ms | 51.66 ms |
| ff56633+dirty | 324.65 ms | 389.38 ms | 64.72 ms |
| ae0e9ff+dirty | 336.33 ms | 381.12 ms | 44.79 ms |
| c67d99f+dirty | 372.11 ms | 398.96 ms | 26.85 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| 15c429b+dirty | 43.94 MiB | 48.90 MiB | 4.96 MiB |
| dcebdb7+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| 5275213+dirty | 43.94 MiB | 48.87 MiB | 4.93 MiB |
| 1eed088+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 028a929+dirty | 43.94 MiB | 48.82 MiB | 4.88 MiB |
| 3cf1cb0+dirty | 7.15 MiB | 8.46 MiB | 1.31 MiB |
| b9f1fe4+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| ff56633+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| ae0e9ff+dirty | 7.15 MiB | 8.44 MiB | 1.28 MiB |
| c67d99f+dirty | 43.94 MiB | 48.88 MiB | 4.94 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c771b48+dirty | 1224.02 ms | 1219.72 ms | -4.30 ms |
| f17e051+dirty | 1193.71 ms | 1223.51 ms | 29.80 ms |
| d1fd647+dirty | 1219.35 ms | 1233.18 ms | 13.83 ms |
| fdbea8b+dirty | 1210.38 ms | 1211.96 ms | 1.57 ms |
| 8db9631+dirty | 1223.60 ms | 1224.56 ms | 0.96 ms |
| 294387d+dirty | 1197.73 ms | 1208.35 ms | 10.61 ms |
| 1226664+dirty | 1220.59 ms | 1221.61 ms | 1.02 ms |
| 90e7cb3+dirty | 1206.61 ms | 1209.46 ms | 2.84 ms |
| f70acbf+dirty | 1235.71 ms | 1243.14 ms | 7.43 ms |
| 95aaf8a+dirty | 1234.78 ms | 1241.94 ms | 7.16 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c771b48+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| f17e051+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| d1fd647+dirty | 2.63 MiB | 3.99 MiB | 1.36 MiB |
| fdbea8b+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| 8db9631+dirty | 2.63 MiB | 4.00 MiB | 1.36 MiB |
| 294387d+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| 1226664+dirty | 2.63 MiB | 4.00 MiB | 1.37 MiB |
| 90e7cb3+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| f70acbf+dirty | 2.63 MiB | 3.98 MiB | 1.34 MiB |
| 95aaf8a+dirty | 2.63 MiB | 3.87 MiB | 1.24 MiB |
Previous results on branch: deps/scripts/update-javascript.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b9f1fe4+dirty | 1236.51 ms | 1238.50 ms | 1.99 ms |
| d8ec252+dirty | 1207.53 ms | 1214.22 ms | 6.69 ms |
| ff56633+dirty | 1212.29 ms | 1214.81 ms | 2.52 ms |
| dcebdb7+dirty | 1199.17 ms | 1206.65 ms | 7.49 ms |
| 3cf1cb0+dirty | 1202.40 ms | 1212.53 ms | 10.13 ms |
| b48c857+dirty | 1219.14 ms | 1240.80 ms | 21.66 ms |
| ba844d2+dirty | 1208.18 ms | 1210.70 ms | 2.52 ms |
| 300c47d+dirty | 1202.78 ms | 1217.14 ms | 14.36 ms |
| 91d4b7d+dirty | 1222.45 ms | 1227.18 ms | 4.73 ms |
| e9ae3ed+dirty | 1217.55 ms | 1213.53 ms | -4.02 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b9f1fe4+dirty | 2.63 MiB | 3.99 MiB | 1.35 MiB |
| d8ec252+dirty | 2.63 MiB | 3.87 MiB | 1.24 MiB |
| ff56633+dirty | 2.63 MiB | 3.87 MiB | 1.24 MiB |
| dcebdb7+dirty | 2.63 MiB | 3.99 MiB | 1.36 MiB |
| 3cf1cb0+dirty | 2.63 MiB | 4.01 MiB | 1.38 MiB |
| b48c857+dirty | 2.63 MiB | 3.96 MiB | 1.33 MiB |
| ba844d2+dirty | 3.44 MiB | 4.59 MiB | 1.15 MiB |
| 300c47d+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 91d4b7d+dirty | 2.63 MiB | 3.91 MiB | 1.28 MiB |
| e9ae3ed+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c771b48+dirty | 1189.46 ms | 1191.15 ms | 1.69 ms |
| f17e051+dirty | 1217.85 ms | 1219.96 ms | 2.11 ms |
| d1fd647+dirty | 1218.16 ms | 1225.82 ms | 7.65 ms |
| fdbea8b+dirty | 1196.19 ms | 1212.09 ms | 15.90 ms |
| 8db9631+dirty | 1226.92 ms | 1226.06 ms | -0.85 ms |
| 294387d+dirty | 1199.23 ms | 1204.16 ms | 4.93 ms |
| 1226664+dirty | 1237.10 ms | 1245.27 ms | 8.16 ms |
| 90e7cb3+dirty | 1212.61 ms | 1213.80 ms | 1.19 ms |
| f70acbf+dirty | 1239.00 ms | 1242.53 ms | 3.53 ms |
| 95aaf8a+dirty | 1206.83 ms | 1213.65 ms | 6.81 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c771b48+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| f17e051+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| d1fd647+dirty | 3.19 MiB | 4.56 MiB | 1.37 MiB |
| fdbea8b+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| 8db9631+dirty | 3.19 MiB | 4.56 MiB | 1.38 MiB |
| 294387d+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| 1226664+dirty | 3.19 MiB | 4.57 MiB | 1.38 MiB |
| 90e7cb3+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| f70acbf+dirty | 3.19 MiB | 4.54 MiB | 1.36 MiB |
| 95aaf8a+dirty | 3.19 MiB | 4.44 MiB | 1.25 MiB |
Previous results on branch: deps/scripts/update-javascript.sh
Startup times
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b9f1fe4+dirty | 1231.24 ms | 1232.77 ms | 1.52 ms |
| d8ec252+dirty | 1223.06 ms | 1219.64 ms | -3.42 ms |
| ff56633+dirty | 1240.96 ms | 1235.77 ms | -5.19 ms |
| dcebdb7+dirty | 1225.80 ms | 1231.29 ms | 5.49 ms |
| 3cf1cb0+dirty | 1231.02 ms | 1221.30 ms | -9.72 ms |
| b48c857+dirty | 1204.78 ms | 1206.73 ms | 1.96 ms |
| ba844d2+dirty | 1201.24 ms | 1213.68 ms | 12.44 ms |
| 300c47d+dirty | 1221.06 ms | 1224.00 ms | 2.94 ms |
| 91d4b7d+dirty | 1221.65 ms | 1215.91 ms | -5.74 ms |
| e9ae3ed+dirty | 1208.33 ms | 1209.12 ms | 0.79 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| b9f1fe4+dirty | 3.19 MiB | 4.55 MiB | 1.37 MiB |
| d8ec252+dirty | 3.19 MiB | 4.44 MiB | 1.25 MiB |
| ff56633+dirty | 3.19 MiB | 4.44 MiB | 1.25 MiB |
| dcebdb7+dirty | 3.19 MiB | 4.56 MiB | 1.37 MiB |
| 3cf1cb0+dirty | 3.19 MiB | 4.58 MiB | 1.39 MiB |
| b48c857+dirty | 3.19 MiB | 4.53 MiB | 1.35 MiB |
| ba844d2+dirty | 3.44 MiB | 4.59 MiB | 1.15 MiB |
| 300c47d+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| 91d4b7d+dirty | 3.19 MiB | 4.48 MiB | 1.29 MiB |
| e9ae3ed+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
Bumps scripts/update-javascript.sh from 10.32.0 to 10.32.1.
Auto-generated by a dependency updater.
Changelog
10.32.1
implementationfield optional (hashroutes) (#18564)Internal Changes
cloudflare-astroe2e test (#18567)