-
-
Notifications
You must be signed in to change notification settings - Fork 356
Fix: Update changelog-preview workflow reference #5527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Semver Impact of This PR⚪ None (no version bump detected) 📋 Changelog PreviewThis is how your changes will appear in the changelog.
🤖 This preview updates automatically when you update the PR. |
antonis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
I've noticed a 403 on the 1st run but worked with the retry.
Android (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c7f264b | 434.98 ms | 452.96 ms | 17.98 ms |
| df83aad+dirty | 420.87 ms | 434.98 ms | 14.11 ms |
| 3099014+dirty | 439.20 ms | 468.40 ms | 29.20 ms |
| 5ee3314+dirty | 415.80 ms | 426.14 ms | 10.34 ms |
| c4e097a | 338.06 ms | 439.36 ms | 101.30 ms |
| ea3e26e+dirty | 498.02 ms | 532.90 ms | 34.88 ms |
| 180638b+dirty | 408.87 ms | 432.04 ms | 23.17 ms |
| f234eb4+dirty | 407.62 ms | 429.64 ms | 22.02 ms |
| 90afdd3+dirty | 375.94 ms | 377.52 ms | 1.58 ms |
| 8ece263 | 441.96 ms | 444.96 ms | 3.00 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| c7f264b | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| df83aad+dirty | 43.75 MiB | 47.99 MiB | 4.24 MiB |
| 3099014+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 5ee3314+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| c4e097a | 17.75 MiB | 19.68 MiB | 1.94 MiB |
| ea3e26e+dirty | 43.75 MiB | 47.99 MiB | 4.24 MiB |
| 180638b+dirty | 43.75 MiB | 48.08 MiB | 4.33 MiB |
| f234eb4+dirty | 17.75 MiB | 19.74 MiB | 1.99 MiB |
| 90afdd3+dirty | 17.75 MiB | 19.70 MiB | 1.95 MiB |
| 8ece263 | 17.75 MiB | 19.68 MiB | 1.94 MiB |
Android (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| df83aad+dirty | 493.94 ms | 521.76 ms | 27.82 ms |
| 8ece263+dirty | 369.44 ms | 414.65 ms | 45.21 ms |
| 2b89ce9+dirty | 372.22 ms | 417.06 ms | 44.84 ms |
| e2fa43d+dirty | 326.56 ms | 372.88 ms | 46.32 ms |
| 161947d+dirty | 349.27 ms | 435.09 ms | 85.82 ms |
| c08359e+dirty | 406.04 ms | 428.87 ms | 22.83 ms |
| c7f264b+dirty | 356.98 ms | 407.46 ms | 50.48 ms |
| 785ffb1+dirty | 380.65 ms | 451.83 ms | 71.18 ms |
| ea3e26e+dirty | 399.98 ms | 448.36 ms | 48.38 ms |
| 180638b+dirty | 434.46 ms | 470.90 ms | 36.44 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| df83aad+dirty | 43.94 MiB | 48.82 MiB | 4.88 MiB |
| 8ece263+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 2b89ce9+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| e2fa43d+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| 161947d+dirty | 7.15 MiB | 8.43 MiB | 1.28 MiB |
| c08359e+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| c7f264b+dirty | 7.15 MiB | 8.41 MiB | 1.26 MiB |
| 785ffb1+dirty | 7.15 MiB | 8.42 MiB | 1.27 MiB |
| ea3e26e+dirty | 43.94 MiB | 48.82 MiB | 4.88 MiB |
| 180638b+dirty | 43.94 MiB | 48.91 MiB | 4.97 MiB |
iOS (legacy) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a0b15d6+dirty | 1220.18 ms | 1223.18 ms | 3.00 ms |
| 8ff81c0+dirty | 1209.17 ms | 1206.15 ms | -3.02 ms |
| 1c38acd+dirty | 1184.71 ms | 1190.31 ms | 5.59 ms |
| 7091004+dirty | 1215.54 ms | 1215.58 ms | 0.04 ms |
| 86584b7+dirty | 1218.82 ms | 1213.38 ms | -5.44 ms |
| 534ba8c+dirty | 1230.22 ms | 1231.18 ms | 0.96 ms |
| 493c1a1+dirty | 1207.58 ms | 1211.80 ms | 4.22 ms |
| e07935d+dirty | 1217.37 ms | 1211.44 ms | -5.93 ms |
| ebf60f9+dirty | 1217.66 ms | 1214.82 ms | -2.84 ms |
| 20daa0a+dirty | 1233.12 ms | 1233.35 ms | 0.22 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a0b15d6+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 8ff81c0+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| 1c38acd+dirty | 3.44 MiB | 4.67 MiB | 1.23 MiB |
| 7091004+dirty | 3.41 MiB | 4.57 MiB | 1.16 MiB |
| 86584b7+dirty | 3.44 MiB | 4.59 MiB | 1.15 MiB |
| 534ba8c+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
| 493c1a1+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| e07935d+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| ebf60f9+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| 20daa0a+dirty | 2.63 MiB | 3.81 MiB | 1.18 MiB |
iOS (new) Performance metrics 🚀
|
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a0b15d6+dirty | 1213.79 ms | 1210.45 ms | -3.34 ms |
| 8ff81c0+dirty | 1219.51 ms | 1221.66 ms | 2.15 ms |
| 1c38acd+dirty | 1214.43 ms | 1216.56 ms | 2.12 ms |
| 7091004+dirty | 1219.11 ms | 1225.98 ms | 6.87 ms |
| 86584b7+dirty | 1199.91 ms | 1210.98 ms | 11.06 ms |
| 534ba8c+dirty | 1225.00 ms | 1237.43 ms | 12.43 ms |
| 493c1a1+dirty | 1220.50 ms | 1221.30 ms | 0.80 ms |
| e07935d+dirty | 1225.85 ms | 1227.72 ms | 1.87 ms |
| ebf60f9+dirty | 1218.85 ms | 1212.53 ms | -6.32 ms |
| 20daa0a+dirty | 1227.71 ms | 1233.72 ms | 6.01 ms |
App size
| Revision | Plain | With Sentry | Diff |
|---|---|---|---|
| a0b15d6+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 8ff81c0+dirty | 3.41 MiB | 4.59 MiB | 1.18 MiB |
| 1c38acd+dirty | 3.44 MiB | 4.67 MiB | 1.23 MiB |
| 7091004+dirty | 3.41 MiB | 4.57 MiB | 1.16 MiB |
| 86584b7+dirty | 3.44 MiB | 4.59 MiB | 1.15 MiB |
| 534ba8c+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
| 493c1a1+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| e07935d+dirty | 3.41 MiB | 4.58 MiB | 1.17 MiB |
| ebf60f9+dirty | 3.41 MiB | 4.67 MiB | 1.25 MiB |
| 20daa0a+dirty | 3.19 MiB | 4.38 MiB | 1.19 MiB |
📢 Type of change
📜 Description
New action was failing herw https://github.com/getsentry/sentry-react-native/actions/runs/20951911312/job/60207383054?pr=5524#logs
The PR bumps the CI version to one that doesn't have this problem
💚 How did you test it?
CI
📝 Checklist
sendDefaultPIIis enabled🔮 Next steps