Skip to content

Conversation

rohitvinnakota-codecov
Copy link
Member

Frontend changes to follow(this will be a toggle on the org settings page). Adds an Enable PR Review + test gen setting at an org level. It must be enabled for the seer-by-sentry app to post PR reviews and generated tests to an org.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 14, 2025
@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review July 14, 2025 18:20
@rohitvinnakota-codecov rohitvinnakota-codecov requested review from a team as code owners July 14, 2025 18:20
@rohitvinnakota-codecov rohitvinnakota-codecov changed the title [draft] Add a enable PR review + test gen at an org level [ft] Add a enable PR review + test gen at an org level Jul 14, 2025


# Used by the seer GH app to check for permissions before posting to an org
def get_organization_seer_consent_by_org_name(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

feels like this name should be changed since its logic is specific to pr review

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree. It's slightly tricky to do right now without breaking things. I can revisit and create a new endpoint + delete the old one after I merge the other PRs.

@rohitvinnakota-codecov rohitvinnakota-codecov merged commit d107dff into master Jul 15, 2025
65 of 66 checks passed
@rohitvinnakota-codecov rohitvinnakota-codecov deleted the rvinnakota-add-enableprtestgen-setting branch July 15, 2025 14:59
Copy link

codecov bot commented Jul 15, 2025

Codecov Report

Attention: Patch coverage is 96.05263% with 3 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../sentry/api/endpoints/test_organization_details.py 75.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #95456      +/-   ##
==========================================
+ Coverage   76.42%   82.88%   +6.45%     
==========================================
  Files       10509    10509              
  Lines      606348   606428      +80     
  Branches    23729    23729              
==========================================
+ Hits       463415   502643   +39228     
+ Misses     142638   103490   -39148     
  Partials      295      295              

rohitvinnakota-codecov added a commit that referenced this pull request Jul 16, 2025
<!-- Describe your PR here. -->

Is consumed by `seer_rpc` while communicating with Seer. This PR must be
merged AFTER #95456 is deployed.

<img width="1011" height="558" alt="Screenshot 2025-07-14 at 1 06 24 PM"
src="https://github.com/user-attachments/assets/0822e352-0a04-473d-b477-57ef3e3a8e3f"
/>


<!--

  Sentry employees and contractors can delete or ignore the following.

-->

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
cursor bot pushed a commit that referenced this pull request Jul 18, 2025
<!-- Describe your PR here. -->

Is consumed by `seer_rpc` while communicating with Seer. This PR must be
merged AFTER #95456 is deployed.

<img width="1011" height="558" alt="Screenshot 2025-07-14 at 1 06 24 PM"
src="https://github.com/user-attachments/assets/0822e352-0a04-473d-b477-57ef3e3a8e3f"
/>


<!--

  Sentry employees and contractors can delete or ignore the following.

-->

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
andrewshie-sentry pushed a commit that referenced this pull request Jul 21, 2025
<!-- Describe your PR here. -->

Frontend changes to follow(this will be a toggle on the org settings
page). Adds an Enable PR Review + test gen setting at an org level. It
must be `enabled` for the `seer-by-sentry` app to post PR reviews and
generated tests to an org.


<!--

  Sentry employees and contractors can delete or ignore the following.

-->

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
andrewshie-sentry pushed a commit that referenced this pull request Jul 21, 2025
<!-- Describe your PR here. -->

Is consumed by `seer_rpc` while communicating with Seer. This PR must be
merged AFTER #95456 is deployed.

<img width="1011" height="558" alt="Screenshot 2025-07-14 at 1 06 24 PM"
src="https://github.com/user-attachments/assets/0822e352-0a04-473d-b477-57ef3e3a8e3f"
/>


<!--

  Sentry employees and contractors can delete or ignore the following.

-->

### Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated
in the State of Delaware in 2015 as Functional Software, Inc. and is
gonna need some rights from me in order to utilize my contributions in
this here PR. So here's the deal: I retain all rights, title and
interest in and to my contributions, and by keeping this boilerplate
intact I confirm that Sentry can use, modify, copy, and redistribute my
contributions, under Sentry's choice of terms.
@github-actions github-actions bot locked and limited conversation to collaborators Jul 31, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants