[ft] Add an org seer toggle for PR review and test gen in Seer

[rohitvinnakota-codecov]

Is consumed by seer_rpc while communicating with Seer. This PR must be merged AFTER #95456 is deployed.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

[roaga]

It might be a confusing UX if the user has this toggle enabled, but "show generative AI features" disabled. Perhaps hide this option if gen AI features are disabled? That's how we handle Seer settings

Also, padding 👁️ 👁️ :

[roaga]

would a link to docs be more appropriate?

[rohan-at-sentry]

I agree

[rohitvinnakota-codecov]

Updated

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #95547       +/-   ##
===========================================
- Coverage   87.73%   77.28%   -10.45%     
===========================================
  Files       10548    10546        -2     
  Lines      607769   607667      -102     
  Branches    23817    23817               
===========================================
- Hits       533215   469664    -63551     
- Misses      74258   137707    +63449     
  Partials      296      296               

[cursor]

Bug: AI Feature Toggle Logic Inverted

The visible callback for the new enablePrReviewTestGeneration field returns hideAiFeatures directly. This inverts the intended logic: the field is displayed when AI features are hidden and hidden when they are enabled. Consequently, users cannot enable the "Enable PR Review and Test Generation" toggle when AI features are active. The callback should return !hideAiFeatures.

static/app/data/forms/organizationGeneralSettings.tsx#L47-L66

sentry/static/app/data/forms/organizationGeneralSettings.tsx

Lines 47 to 66 in 4aad704

	{
	name: 'enablePrReviewTestGeneration',
	type: 'boolean',
	label: tct('Enable PR Review and Test Generation [badge]', {
	badge: <FeatureBadge type="beta" style={{marginBottom: '2px'}} />,
	}),
	help: tct(
	'Use AI to generate feedback and tests in pull requests [link:Learn more]',
	{
	link: (
	<ExternalLink href="https://docs.sentry.io/product/ai-in-sentry/sentry-prevent-ai/" />
	),
	}
	),
	visible: ({model}) => {
	// Show field when AI features are enabled (hideAiFeatures is false)
	const hideAiFeatures = model.getValue('hideAiFeatures');
	return hideAiFeatures;
	},
	},

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎

[roaga]

I think this is backwards?

[rohitvinnakota-codecov]

It's very confusing. The logic was inverted at some point, you can test on the UI

[rohitvinnakota-codecov]

I think we need to change the variable name, but it touches a lot of other areas as well

[rohitvinnakota-codecov]

sentry/static/app/views/settings/organizationGeneralSettings/aiFeatureSettings.tsx

Line 30 in 0b995e8

return !value;

[roaga]

ack ok