chore(feedback): prep Feedback model to be deleted #99379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Backend
|
This PR has a migration; here is the generated SQL for for --
-- Alter field environment on feedback
--
SET CONSTRAINTS "feedback_feedback_environment_id_fab8783f_fk_sentry_en" IMMEDIATE; ALTER TABLE "feedback_feedback" DROP CONSTRAINT "feedback_feedback_environment_id_fab8783f_fk_sentry_en";
--
-- Moved model feedback to pending deletion state
--
-- (no-op) |
wedamija
approved these changes
Sep 12, 2025
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #99379 +/- ##
==========================================
- Coverage 81.19% 81.19% -0.01%
==========================================
Files 8591 8590 -1
Lines 380188 380142 -46
Branches 24122 24115 -7
==========================================
- Hits 308703 308660 -43
+ Misses 71131 71129 -2
+ Partials 354 353 -1 |
jerryzhou196
added a commit
that referenced
this pull request
Sep 15, 2025
This is Stage 2 for removing the `Feedback` Model. Follow-up to #99379 that removes the `environment` FK field as per our [Develop Migration Docs](https://develop.sentry.dev/backend/application-domains/database-migrations/#deleting-tables)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Stage 1 for removing the
Feedbackmodel.Sets the
FeedbackFK to not be a db constraint as per the Develop Migrations Docs