Skip to content

Conversation

jerryzhou196
Copy link
Contributor

@jerryzhou196 jerryzhou196 commented Sep 12, 2025

This is Stage 2 for removing the Feedback Model.

Follow-up to #99379 that removes the environment FK field as per our Develop Migration Docs

@jerryzhou196 jerryzhou196 requested review from a team as code owners September 12, 2025 15:58
Copy link

linear bot commented Sep 12, 2025

@github-actions github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Sep 12, 2025
Copy link

codecov bot commented Sep 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #99380      +/-   ##
==========================================
+ Coverage   80.68%   81.19%   +0.51%     
==========================================
  Files        8594     8591       -3     
  Lines      380293   380150     -143     
  Branches    24144    24115      -29     
==========================================
+ Hits       306824   308662    +1838     
+ Misses      73115    71135    -1980     
+ Partials      354      353       -1     

@jerryzhou196 jerryzhou196 force-pushed the REPLAY-610-clean-up-postgres-model-2 branch from fd5c839 to fb1217f Compare September 12, 2025 16:19
@jerryzhou196 jerryzhou196 changed the title chore(feedback) remove environment FK field chore(feedback) remove Feedback model Sep 12, 2025
Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/feedback/migrations/0005_feedback_fk_not_db_contstr.py src/sentry/feedback/migrations/0006_safe_del_feedback_model.py

for 0005_feedback_fk_not_db_contstr in feedback

--
-- Alter field environment on feedback
--
SET CONSTRAINTS "feedback_feedback_environment_id_fab8783f_fk_sentry_en" IMMEDIATE; ALTER TABLE "feedback_feedback" DROP CONSTRAINT "feedback_feedback_environment_id_fab8783f_fk_sentry_en";
--
-- Moved model feedback to pending deletion state
--
-- (no-op)

for 0006_safe_del_feedback_model in feedback

--
-- Delete model feedback
--
DROP TABLE "feedback_feedback" CASCADE;

Copy link
Member

@wedamija wedamija left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - please don't merge this until the previous pr has fully deployed

@jerryzhou196
Copy link
Contributor Author

sounds good.

Copy link
Contributor

This PR has a migration; here is the generated SQL for src/sentry/feedback/migrations/0006_safe_del_feedback_model.py

for 0006_safe_del_feedback_model in feedback

--
-- Delete model feedback
--
DROP TABLE "feedback_feedback" CASCADE;

Copy link
Member

@aliu39 aliu39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jerryzhou196 jerryzhou196 merged commit 16b3832 into master Sep 15, 2025
64 of 65 checks passed
@jerryzhou196 jerryzhou196 deleted the REPLAY-610-clean-up-postgres-model-2 branch September 15, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Scope: Backend Automatically applied to PRs that change backend components
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants