Skip to content

Conversation

@hickford
Copy link
Contributor

@hickford hickford commented Oct 19, 2023

@hickford hickford force-pushed the gitea branch 2 times, most recently from 1f6cc72 to 4c83069 Compare October 19, 2023 21:27
@hickford hickford marked this pull request as ready for review October 19, 2023 21:29
@hickford hickford force-pushed the gitea branch 5 times, most recently from 4db5fd4 to eb19633 Compare October 20, 2023 01:47
Copy link
Contributor

@mjcheetham mjcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see Gitea has a universal app registration for GCM (and credential-oauth)!

Just two comments on structure/style of constants and case matching.

@mjcheetham mjcheetham added the auth:oauth Specific to OAuth2 authentication label Oct 23, 2023
Co-authored-by: Matthew John Cheetham <[email protected]>
Copy link
Contributor

@mjcheetham mjcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you

@mjcheetham mjcheetham merged commit 6e06153 into git-ecosystem:main Oct 24, 2023
mjcheetham added a commit that referenced this pull request Nov 1, 2023
**Changes:**

- Add support for managed identity and service principals in Azure Repos
(#1372)
- Support universal Gitea OAuth app configuration (#1442)
- Set default generic OAuth redirect URI value (#1444)
- Drop WPF helpers on Windows (#1417)
- Add software rendering override for Windows (#1445, #1453)
- Recognise GitLab hosts via WWW-Authenticate header (#1428)
- Recognise Bitbucket hosts via WWW-Authenticate header (#1441)
- Support GitHub Gist remote URLs (#1402)
- Update to Avalonia 11.x (#1383)
- Documentation updates (#1416)
- Drop unnecessary .NET Framework-specific code (#1447)
- Updates to release process (#1386, #1381)
- Update code signing certificates (#1431)
mjcheetham added a commit that referenced this pull request Nov 1, 2023
**Changes:**

_Since 2.4.0:_

- Fix macOS ARM64 tarball contents (#1458)

_Since 2.3.x:_

- Add support for managed identity and service principals in Azure Repos
(#1372)
- Support universal Gitea OAuth app configuration (#1442)
- Set default generic OAuth redirect URI value (#1444)
- Drop WPF helpers on Windows (#1417)
- Add software rendering override for Windows (#1445, #1453)
- Recognise GitLab hosts via WWW-Authenticate header (#1428)
- Recognise Bitbucket hosts via WWW-Authenticate header (#1441)
- Support GitHub Gist remote URLs (#1402)
- Update to Avalonia 11.x (#1383)
- Documentation updates (#1416)
- Drop unnecessary .NET Framework-specific code (#1447)
- Updates to release process (#1386, #1381)
- Update code signing certificates (#1431)
MissLov3ly

This comment was marked as off-topic.

@ghost
Copy link

ghost commented Jan 31, 2024

doesn't seem to work on linux or with vs code

#1514

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

auth:oauth Specific to OAuth2 authentication

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automatic Gitea OAuth support

4 participants