Skip to content

Conversation

@mjcheetham
Copy link
Contributor

@mjcheetham mjcheetham commented Oct 20, 2023

Add ability to disable hardware acceleration when drawing Avalonia-based GUI prompts on Windows. This is a useful workaround for an issue on certain ARM64 devices where the windows appear empty.

AvaloniaUI/Avalonia#10405
https://developercommunity.visualstudio.com/t/Git-authentication-dialog-is-invisible-o/10467795

The issue AvaloniaUI/Avalonia#10296 has been
fixed so we can now remove this workaround.
Introduce a flag to switch Avalonia to use software rendering rather
than hardware/GPU-based. There is an open Avalonia issue[1] on Windows
when run on certain ARM64 GPUs. Until this is solved, introduce this
workaround flag.

[1]: AvaloniaUI/Avalonia#10405
@mjcheetham mjcheetham added the gui Specific to graphical user interface controls label Oct 20, 2023
@mjcheetham mjcheetham self-assigned this Oct 20, 2023
@mjcheetham mjcheetham added bug A bug in Git Credential Manager platform:windows Specific to the Windows platform labels Oct 20, 2023
@mjcheetham mjcheetham force-pushed the win32-software-rendering branch from b425b13 to d0396e6 Compare October 23, 2023 19:18
Default to software GUI rendering on Windows on ARM.
Users can explicitly set the config to re-enable HW accelerated
rendering if they wish.
@mjcheetham mjcheetham force-pushed the win32-software-rendering branch from d0396e6 to 3183801 Compare October 25, 2023 14:55
@mjcheetham mjcheetham merged commit b30eab3 into git-ecosystem:main Oct 25, 2023
@mjcheetham mjcheetham deleted the win32-software-rendering branch October 25, 2023 19:09
@git-ecosystem git-ecosystem deleted a comment Oct 25, 2023
@mjcheetham
Copy link
Contributor Author

@shango420 please do not use this repository to practice using GitHub. Please also be careful what information you are sharing. The last comment you added (that I have now deleted) seemed to contain an sensitive access token.

mjcheetham added a commit to mjcheetham/git-credential-manager that referenced this pull request Oct 30, 2023
In removing the Avalonia setup workaround in git-ecosystem#1445 we forget to replace
the SetupWithLifetime call with just SetupWithoutStarting!
mjcheetham added a commit that referenced this pull request Oct 30, 2023
In removing the Avalonia setup workaround in #1445 we forget to replace
the SetupWithLifetime call with just SetupWithoutStarting!
mjcheetham added a commit that referenced this pull request Nov 1, 2023
**Changes:**

- Add support for managed identity and service principals in Azure Repos
(#1372)
- Support universal Gitea OAuth app configuration (#1442)
- Set default generic OAuth redirect URI value (#1444)
- Drop WPF helpers on Windows (#1417)
- Add software rendering override for Windows (#1445, #1453)
- Recognise GitLab hosts via WWW-Authenticate header (#1428)
- Recognise Bitbucket hosts via WWW-Authenticate header (#1441)
- Support GitHub Gist remote URLs (#1402)
- Update to Avalonia 11.x (#1383)
- Documentation updates (#1416)
- Drop unnecessary .NET Framework-specific code (#1447)
- Updates to release process (#1386, #1381)
- Update code signing certificates (#1431)
mjcheetham added a commit that referenced this pull request Nov 1, 2023
**Changes:**

_Since 2.4.0:_

- Fix macOS ARM64 tarball contents (#1458)

_Since 2.3.x:_

- Add support for managed identity and service principals in Azure Repos
(#1372)
- Support universal Gitea OAuth app configuration (#1442)
- Set default generic OAuth redirect URI value (#1444)
- Drop WPF helpers on Windows (#1417)
- Add software rendering override for Windows (#1445, #1453)
- Recognise GitLab hosts via WWW-Authenticate header (#1428)
- Recognise Bitbucket hosts via WWW-Authenticate header (#1441)
- Support GitHub Gist remote URLs (#1402)
- Update to Avalonia 11.x (#1383)
- Documentation updates (#1416)
- Drop unnecessary .NET Framework-specific code (#1447)
- Updates to release process (#1386, #1381)
- Update code signing certificates (#1431)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug A bug in Git Credential Manager gui Specific to graphical user interface controls platform:windows Specific to the Windows platform

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants