diagnose: avoid polluting stderr stream in Git diagnostic #1590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid poluting the standard error stream with a 'fatal' Git error message during the Git diagnostic run as part of the `diagnose` command. When checking if we are inside of a Git repo we should be using an explicit check for `IGit::IsInsideRepository` rather than trying to get the current repo path and checking for null.
mjcheetham
force-pushed
the
fix-git-diag
branch
from
f932072 to
eb6cd02
Compare
vdye
approved these changes
Apr 17, 2024
Merged
mjcheetham
added a commit
that referenced
this pull request
Apr 18, 2024
dscho
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid poluting the standard error stream with a 'fatal' Git error message during the Git diagnostic run as part of the
diagnosecommand.When checking if we are inside of a Git repo we should be using an explicit check for
IGit::IsInsideRepositoryrather than trying to get the current repo path and checking for null.