Java: sensitive logging query exclude null in variable name #15786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
java/ql/src/change-notes/2024-03-04-sensitive-log-remove-null-from-sources.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Tony Torralba <[email protected]>
atorralba
approved these changes
Mar 4, 2024
Contributor
Author
|
I ran variant analysis on the top 1000 java repos to see how many alerts would be removed. The answer is very few: 22 from |
owen-mc
deleted the
java/sensitive-logging-query-exclude-null-in-variable-name
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some FPs in
apache/geodewhere the source was a variable calledNULLTOKEN. It is an easy fix to exclude variable names that match "null" (case-insensitively) from the sources.