Skip to content

Java: sensitive logging query exclude null in variable name #15786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 4, 2024
Merged

Java: sensitive logging query exclude null in variable name #15786

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
c7efde3
Remove variables with "null" in their name as sources
owen-mc Mar 3, 2024
19ac9e0
Add test
owen-mc Mar 3, 2024
7a96b11
Add change note
owen-mc Mar 3, 2024
037c76d
Update change note
owen-mc Mar 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add test
  • Loading branch information
@owen-mc
owen-mc committed Mar 3, 2024
commit 19ac9e089ad516a5edd0835577ba6d672dfd004b
6 changes: 6 additions & 0 deletions java/ql/test/query-tests/security/CWE-532/Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,10 @@ void test3(String username) {
logger.error("Auth failed for: " + username); // Safe
}

void test4(String nullToken) {
Logger logger = null;

logger.error("Auth failed for: " + nullToken); // Safe
}

}