-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Prevent pending toggle to get reset #21733
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 11.0/bugfixes
Are you sure you want to change the base?
Conversation
… ticket ITIL object
|
I can see that the TinyMCE content is cleared when choosing a template. So still WIP. |
|
Fixed content clearing : if the followup template has no content in it, TinyMCE is not cleared (l.289 - 291), assuming the user would add his own content w/o an "empty" template. |
AdrienClairembault
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good but I guess the same should be done on task templates then?
AdrienClairembault
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See previous comment
cedric-anne
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check if the same fix must be applied to task form.
Description
Root Cause:
The JavaScript function itilfollowuptemplate_update() was unconditionally clearing the pending status when applying a followup template without a pending reason. Two issues:
Fix:
Removed the automatic clearing logic. Now the code only applies pending fields if the template explicitly defines them (data.pendingreasons_id > 0). If the template has no pending
defined, user's choices are preserved (do nothing).