Skip to content

Replace list.List with slices #16311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Aug 9, 2021
Merged

Replace list.List with slices #16311

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
99f5c8c
Replaced list with slice.
KN4CK3R Jun 29, 2021
a0f9e9d
Merge branch 'main' of https://github.com/go-gitea/gitea into refacto…
KN4CK3R Jun 29, 2021
f236707
Fixed usage of pointer to temporary variable.
KN4CK3R Jun 30, 2021
d226063
Replaced LIFO list with slice.
KN4CK3R Jun 30, 2021
5390964
Lint
KN4CK3R Jun 30, 2021
5ad2fd5
Removed type check.
KN4CK3R Jun 30, 2021
bfb61b8
Removed duplicated code.
KN4CK3R Jun 30, 2021
53d88b4
Merge branch 'main' of https://github.com/go-gitea/gitea into refacto…
KN4CK3R Jul 20, 2021
1e0158f
Lint
KN4CK3R Jul 20, 2021
d3a6598
Fixed merge.
KN4CK3R Jul 22, 2021
7465a24
Merge branch 'main' into refactor-list
6543 Jul 23, 2021
32f8cfb
Merge branch 'main' of https://github.com/go-gitea/gitea into refacto…
KN4CK3R Aug 9, 2021
9c1dd3a
Merge branch 'main' into refactor-list
6543 Aug 9, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Removed type check.
  • Loading branch information
@KN4CK3R
KN4CK3R committed Jun 30, 2021
commit 5ad2fd588ce7721baf34b01f46a7d5ec42d5023c
12 changes: 0 additions & 12 deletions modules/templates/helper.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,18 +297,6 @@ func NewFuncMap() []template.FuncMap {
},
"CommentMustAsDiff": gitdiff.CommentMustAsDiff,
"MirrorRemoteAddress": mirrorRemoteAddress,
"CommitType": func(commit interface{}) string {
switch commit.(type) {
case models.SignCommitWithStatuses:
return "SignCommitWithStatuses"
case models.SignCommit:
return "SignCommit"
case models.UserCommit:
return "UserCommit"
default:
return ""
}
},
"NotificationSettings": func() map[string]interface{} {
return map[string]interface{}{
"MinTimeout": int(setting.UI.Notification.MinTimeout / time.Millisecond),
Expand Down
7 changes: 5 additions & 2 deletions routers/web/repo/wiki.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -312,8 +312,11 @@ func renderRevisionPage(ctx *context.Context) (*git.Repository, *git.TreeEntry)
ctx.ServerError("CommitsByFileAndRangeNoFollow", err)
return nil, nil
}
ctx.Data["Commits"] = models.ParseCommitsWithSignature(
models.ValidateCommitsWithEmails(commitsHistory),
ctx.Data["Commits"] = models.ParseCommitsWithStatus(
models.ParseCommitsWithSignature(
models.ValidateCommitsWithEmails(commitsHistory),
ctx.Repo.Repository,
),
ctx.Repo.Repository,
)

Expand Down
4 changes: 1 addition & 3 deletions templates/repo/commits_list.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,9 +68,7 @@
{{if IsMultilineCommitMessage .Message}}
<button class="basic compact mini ui icon button commit-button"><i class="ellipsis horizontal icon"></i></button>
{{end}}
{{if eq (CommitType .) "SignCommitWithStatuses"}}
{{template "repo/commit_statuses" dict "Status" .Status "Statuses" .Statuses "root" $}}
{{end}}
{{template "repo/commit_statuses" dict "Status" .Status "Statuses" .Statuses "root" $}}
{{if IsMultilineCommitMessage .Message}}
<pre class="commit-body" style="display: none;">{{RenderCommitBody .Message $.RepoLink $.Repository.ComposeMetas}}</pre>
{{end}}
Expand Down
4 changes: 1 addition & 3 deletions templates/repo/commits_list_small.tmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,7 @@
{{end}}

<span class="ui float right shabox">
{{if eq (CommitType .) "SignCommitWithStatuses"}}
{{template "repo/commit_statuses" dict "Status" .Status "Statuses" .Statuses "root" $.root}}
{{end}}
{{template "repo/commit_statuses" dict "Status" .Status "Statuses" .Statuses "root" $.root}}
{{$class := "ui sha label"}}
{{if .Signature}}
{{$class = (printf "%s%s" $class " isSigned")}}
Expand Down