Fixed usage of pointer to temporary variable.

models/commit_status.go

@@ -256,12 +256,12 @@ type SignCommitWithStatuses struct {
 }
 
 // ParseCommitsWithStatus checks commits latest statuses and calculates its worst status state
-func ParseCommitsWithStatus(oldCommits []SignCommit, repo *Repository) []SignCommitWithStatuses {
-	newCommits := make([]SignCommitWithStatuses, 0, len(oldCommits))
+func ParseCommitsWithStatus(oldCommits []*SignCommit, repo *Repository) []*SignCommitWithStatuses {
+	newCommits := make([]*SignCommitWithStatuses, 0, len(oldCommits))
 
 	for _, c := range oldCommits {
-		commit := SignCommitWithStatuses{
-			SignCommit: &c,
+		commit := &SignCommitWithStatuses{
+			SignCommit: c,
 		}
 		statuses, err := GetLatestCommitStatus(repo.ID, commit.ID.String(), ListOptions{})
 		if err != nil {

models/gpg_key.go

@@ -829,13 +829,13 @@ func verifyWithGPGSettings(gpgSettings *git.GPGSettings, sig *packet.Signature,
 }
 
 // ParseCommitsWithSignature checks if signaute of commits are corresponding to users gpg keys.
-func ParseCommitsWithSignature(oldCommits []UserCommit, repository *Repository) []SignCommit {
-	newCommits := make([]SignCommit, 0, len(oldCommits))
+func ParseCommitsWithSignature(oldCommits []*UserCommit, repository *Repository) []*SignCommit {
+	newCommits := make([]*SignCommit, 0, len(oldCommits))
 	keyMap := map[string]bool{}
 
 	for _, c := range oldCommits {
-		signCommit := SignCommit{
-			UserCommit:   &c,
+		signCommit := &SignCommit{
+			UserCommit:   c,
 			Verification: ParseCommitWithSignature(c.Commit),
 		}
 

models/issue_comment.go

@@ -191,11 +191,11 @@ type Comment struct {
 	RefIssue   *Issue      `xorm:"-"`
 	RefComment *Comment    `xorm:"-"`
 
-	Commits     []SignCommitWithStatuses `xorm:"-"`
-	OldCommit   string                   `xorm:"-"`
-	NewCommit   string                   `xorm:"-"`
-	CommitsNum  int64                    `xorm:"-"`
-	IsForcePush bool                     `xorm:"-"`
+	Commits     []*SignCommitWithStatuses `xorm:"-"`
+	OldCommit   string                    `xorm:"-"`
+	NewCommit   string                    `xorm:"-"`
+	CommitsNum  int64                     `xorm:"-"`
+	IsForcePush bool                      `xorm:"-"`
 }
 
 // PushActionContent is content of push pull comment

models/user.go

@@ -1502,10 +1502,10 @@ func ValidateCommitWithEmail(c *git.Commit) *User {
 }
 
 // ValidateCommitsWithEmails checks if authors' e-mails of commits are corresponding to users.
-func ValidateCommitsWithEmails(oldCommits []*git.Commit) []UserCommit {
+func ValidateCommitsWithEmails(oldCommits []*git.Commit) []*UserCommit {
 	var (
 		emails     = make(map[string]*User)
-		newCommits = make([]UserCommit, 0, len(oldCommits))
+		newCommits = make([]*UserCommit, 0, len(oldCommits))
 	)
 	for _, c := range oldCommits {
 		var u *User
@@ -1518,7 +1518,7 @@ func ValidateCommitsWithEmails(oldCommits []*git.Commit) []UserCommit {
 			}
 		}
 
-		newCommits = append(newCommits, UserCommit{
+		newCommits = append(newCommits, &UserCommit{
 			User:   u,
 			Commit: c,
 		})

routers/web/repo/blame.go

@@ -137,9 +137,9 @@ func RefBlame(ctx *context.Context) {
 	ctx.HTML(http.StatusOK, tplBlame)
 }
 
-func processBlameParts(ctx *context.Context, blameParts []git.BlamePart) (map[string]models.UserCommit, map[string]string) {
+func processBlameParts(ctx *context.Context, blameParts []git.BlamePart) (map[string]*models.UserCommit, map[string]string) {
 	// store commit data by SHA to look up avatar info etc
-	commitNames := make(map[string]models.UserCommit)
+	commitNames := make(map[string]*models.UserCommit)
 	// previousCommits contains links from SHA to parent SHA,
 	// if parent also contains the current TreePath.
 	previousCommits := make(map[string]string)
@@ -190,8 +190,6 @@ func processBlameParts(ctx *context.Context, blameParts []git.BlamePart) (map[st
 		}
 
 		commits = append(commits, commit)
-
-		commitNames[commit.ID.String()] = models.UserCommit{}
 	}
 
 	// populate commit email addresses to later look up avatars.
@@ -202,7 +200,7 @@ func processBlameParts(ctx *context.Context, blameParts []git.BlamePart) (map[st
 	return commitNames, previousCommits
 }
 
-func renderBlame(ctx *context.Context, blameParts []git.BlamePart, commitNames map[string]models.UserCommit, previousCommits map[string]string) {
+func renderBlame(ctx *context.Context, blameParts []git.BlamePart, commitNames map[string]*models.UserCommit, previousCommits map[string]string) {
 	repoLink := ctx.Repo.RepoLink
 
 	var lines = make([]string, 0)