feat(log): Support paging on vela get log
#427
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added to server in go-vela/server#798 Added to sdk-go in go-vela/sdk-go#216
This was referenced Mar 28, 2023
cognifloyd
changed the title
vela get log
Member
Author
|
Implemented in #431 |
Collaborator
|
My fault, I didn't realize you had already worked on this :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
pageandper_pagequery parameters invela get log(endpoint/api/v1/repos/+/+/builds/+/logs).The server-side default changed from
per_page=100toper_page=10in go-vela/server#798, so the cli arg here defaults to 100 to maintain the same behavior that users experienced before. But, now they can get additional pages of logs if there are more than 100, or they can lower the per_page amount if they want to see fewer.Depends on:
GetBuildLogsserver#798BuildService.GetLogssdk-go#216