feat(build)!: Support paging on BuildService.GetLogs
#216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added to server in go-vela/server#798
cognifloyd
changed the title
BuildService.GetLogs
cognifloyd
added a commit
to go-vela/cli
that referenced
this pull request
Mar 28, 2023
Added to server in go-vela/server#798 Added to sdk-go in go-vela/sdk-go#216
This was referenced Mar 28, 2023
Member
Author
|
Follow-up PR to review/merge once this one is merged: |
cognifloyd
changed the title
BuildService.GetLogsBuildService.GetLogs
Codecov Report
@@ Coverage Diff @@
## main #216 +/- ##
==========================================
- Coverage 91.73% 91.54% -0.20%
==========================================
Files 18 18
Lines 1379 1383 +4
==========================================
+ Hits 1265 1266 +1
- Misses 84 86 +2
- Partials 30 31 +1
|
wass3rw3rk
approved these changes
Apr 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the
pageandper_pagequery parameters inBuildService.GetLogs(endpoint/api/v1/repos/+/+/builds/+/logs).BREAKING CHANGE: Calling
BuildService.GetLogsnow requires passing a new arg: pass either*ListOptionsornil.Depends on go-vela/server#798