Skip to content

Conversation

@wass3rw3rk
Copy link
Member

@wass3rw3rk wass3rw3rk commented Apr 5, 2023

adds ability to:

  • view worker(s)
  • update workers (platform admin only)
  • add workers (platform admin only)

dependent on:
go-vela/sdk-go#218
go-vela/worker#457
go-vela/server#798

also, needs docs PR

@wass3rw3rk wass3rw3rk marked this pull request as ready for review April 7, 2023 15:23
@wass3rw3rk wass3rw3rk requested a review from a team as a code owner April 7, 2023 15:23
@wass3rw3rk wass3rw3rk marked this pull request as draft April 7, 2023 15:26
@wass3r wass3r marked this pull request as ready for review April 7, 2023 17:00
@codecov
Copy link

codecov bot commented Apr 7, 2023

Codecov Report

Merging #430 (6d2e4b6) into main (4612e32) will increase coverage by 0.62%.
The diff coverage is 95.10%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #430      +/-   ##
==========================================
+ Coverage   85.38%   86.00%   +0.62%     
==========================================
  Files         122      132      +10     
  Lines        5386     5754     +368     
==========================================
+ Hits         4599     4949     +350     
- Misses        648      660      +12     
- Partials      139      145       +6     
Impacted Files Coverage Δ
action/repo/get.go 93.61% <ø> (ø)
command/worker/get.go 73.91% <73.91%> (ø)
command/worker/add.go 88.00% <88.00%> (ø)
command/worker/view.go 88.00% <88.00%> (ø)
command/worker/update.go 88.46% <88.46%> (ø)
action/worker/get.go 92.30% <92.30%> (ø)
action/worker/add.go 100.00% <100.00%> (ø)
action/worker/table.go 100.00% <100.00%> (ø)
action/worker/update.go 100.00% <100.00%> (ø)
action/worker/validate.go 100.00% <100.00%> (ø)
... and 1 more

@plyr4
Copy link
Contributor

plyr4 commented Apr 11, 2023

LGTM, just some very minor wording tweaks

plyr4
plyr4 previously approved these changes Apr 13, 2023
Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@wass3rw3rk wass3rw3rk merged commit 878f13c into main Apr 14, 2023
@wass3rw3rk wass3rw3rk deleted the feat/manage-worker branch April 14, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants