This repository was archived by the owner on Jan 27, 2025. It is now read-only.
feat(worker): add worker commands #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecrupper
suggested changes
Apr 25, 2023
Contributor
ecrupper
left a comment
ecrupper
left a comment
There was a problem hiding this comment.
Nice — couple things I noticed
Co-authored-by: Easton Crupper <[email protected]>
plyr4
reviewed
Apr 25, 2023
content/reference/cli/worker/add.md
Outdated
| #### Request | ||
|
|
||
| ```sh | ||
| $ vela add worker --worker.hostname MyWorker --worker.address myworker.example.com |
Contributor
There was a problem hiding this comment.
minor, should we include protocol?
Suggested change
| $ vela add worker --worker.hostname MyWorker --worker.address myworker.example.com | |
| $ vela add worker --worker.hostname MyWorker --worker.address https://myworker.example.com |
Contributor
There was a problem hiding this comment.
meh, not necessary, that should be inferred
ecrupper
approved these changes
Apr 25, 2023
plyr4
approved these changes
Apr 25, 2023
timhuynh94
approved these changes
Apr 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for go-vela/cli#430