Skip to content

Conversation

@ecrupper
Copy link
Contributor

@ecrupper ecrupper commented Apr 3, 2025

A few breaking changes to function naming / returns and what not from the v2->v3 change. Addressing those in this PR

@ecrupper ecrupper requested a review from a team as a code owner April 3, 2025 19:09
@codecov
Copy link

codecov bot commented Apr 3, 2025

Codecov Report

Attention: Patch coverage is 27.77778% with 13 lines in your changes missing coverage. Please review.

Project coverage is 55.92%. Comparing base (034370c) to head (fb1caed).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
database/testutils/mock_args.go 0.00% 5 Missing ⚠️
database/jwk/create.go 50.00% 2 Missing and 1 partial ⚠️
database/types/jwk.go 40.00% 2 Missing and 1 partial ⚠️
database/testutils/api_resources.go 0.00% 1 Missing ⚠️
internal/token/generate_rsa.go 0.00% 1 Missing ⚠️

❌ Your project status has failed because the head coverage (55.92%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1287      +/-   ##
==========================================
- Coverage   55.93%   55.92%   -0.01%     
==========================================
  Files         631      631              
  Lines       35501    35509       +8     
==========================================
+ Hits        19858    19860       +2     
- Misses      15017    15021       +4     
- Partials      626      628       +2     
Files with missing lines Coverage Δ
database/jwk/get.go 100.00% <ø> (ø)
database/jwk/list.go 76.00% <ø> (ø)
mock/server/authentication.go 0.00% <ø> (ø)
database/testutils/api_resources.go 0.00% <0.00%> (ø)
internal/token/generate_rsa.go 0.00% <0.00%> (ø)
database/jwk/create.go 82.35% <50.00%> (-17.65%) ⬇️
database/types/jwk.go 77.14% <40.00%> (-6.73%) ⬇️
database/testutils/mock_args.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ecrupper ecrupper merged commit b8e3eaa into main Apr 4, 2025
14 of 16 checks passed
@ecrupper ecrupper deleted the chore/jwx-v3 branch April 4, 2025 15:27
timhuynh94 pushed a commit that referenced this pull request Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants