Skip to content

Conversation

@ecrupper
Copy link
Contributor

I believe this change is causing the SkipTransaction config to overwrite the dialector Postgres config, resulting in the fallback to Sqlite and failing tests. I didn't want to go into the weeds and see if this is actually a bug or if it's some intended thing, so I just made a helper function that handles it gracefully regardless.

@ecrupper ecrupper requested a review from a team as a code owner August 25, 2025 20:48
@codecov
Copy link

codecov bot commented Aug 25, 2025

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 56.86%. Comparing base (65665ec) to head (4ab6cc3).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
database/testutils/postgres_init.go 0.00% 8 Missing ⚠️

❌ Your project status has failed because the head coverage (56.86%) is below the target coverage (90.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1342      +/-   ##
==========================================
- Coverage   56.87%   56.86%   -0.02%     
==========================================
  Files         646      647       +1     
  Lines       36691    36699       +8     
==========================================
  Hits        20868    20868              
- Misses      15167    15175       +8     
  Partials      656      656              
Files with missing lines Coverage Δ
database/testutils/postgres_init.go 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think this is intentional and going to stick around. i spent a bit of time on it a couple of weeks ago.

@ecrupper ecrupper merged commit 652bc2f into main Aug 26, 2025
15 of 16 checks passed
@ecrupper ecrupper deleted the chore/gorm-upgrade branch August 26, 2025 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants