fix(api/secret): get rid of whitespace check for secret updating #598
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #598 +/- ##
==========================================
+ Coverage 54.32% 54.35% +0.02%
==========================================
Files 181 181
Lines 15177 15169 -8
==========================================
Hits 8245 8245
+ Misses 6615 6607 -8
Partials 317 317
|
plyr4
approved these changes
Feb 28, 2022
plyr4
approved these changes
Feb 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to update a secret to handle more events, I received a
400because I wanted to keep the value of the secret the same. In other words, we already handle whitespace updates by simply keeping the original secret value — we don't need this check; in fact, it's just a bug if we leave it.