Skip to content

fix(api/secret): get rid of whitespace check for secret updating #598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecrupper merged 2 commits into from
Mar 3, 2022
Merged

fix(api/secret): get rid of whitespace check for secret updating #598

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e02b210
get rid of whitespace check for secret updating
ecrupper Feb 26, 2022
c69ff97
Merge branch 'master' into fix/update-secret-fix
ecrupper Mar 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions api/secret.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,16 +609,6 @@ func UpdateSecret(c *gin.Context) {
return
}

// reject secrets with solely whitespace characters as its value
trimmed := strings.TrimSpace(input.GetValue())
if len(trimmed) == 0 {
retErr := fmt.Errorf("secret value must contain non-whitespace characters")

util.HandleError(c, http.StatusBadRequest, retErr)

return
}

// update secret fields if provided
input.SetName(s)
input.SetOrg(o)
Expand Down