enhance(build): return build on CreateBuild and UpdateBuild #701
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #701 +/- ##
==========================================
- Coverage 58.08% 55.10% -2.99%
==========================================
Files 255 201 -54
Lines 15876 15972 +96
==========================================
- Hits 9222 8801 -421
- Misses 6249 6789 +540
+ Partials 405 382 -23
|
ecrupper
changed the title
cognifloyd
approved these changes
Mar 21, 2023
jbrockopp
requested changes
Apr 5, 2023
| return nil, err | ||
| } | ||
|
|
||
| return build.Crop().ToLibrary(), nil |
Contributor
There was a problem hiding this comment.
Have we confirmed the build object has the ID field populated with this change?
We don't explicitly set that ID field in our codebase which is why I ask.
Member
There was a problem hiding this comment.
When gorm saves the object, it populates the ID field, right?
Contributor
Author
|
closing because this has become a mess. Will just use a new branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the effort for go-vela/community#613. It would be helpful to not have to make two calls to the database during our webhook process. This can be remedied by returning the created build object when it's saved to the database.