feat(api): add support for schedules #836

JordanSussman · 2023-05-03T15:06:17Z

xref: go-vela/community#538

Part of go-vela/community#772

Dependent on #833 and #834

The code that manages the execution of schedules will added in a separate code change.

…to feature/schedule/database

codecov · 2023-05-03T15:07:26Z

Codecov Report

Merging #836 (d601eba) into main (3919d6c) will decrease coverage by 1.09%.
The diff coverage is 10.21%.

@@            Coverage Diff             @@
##             main     #836      +/-   ##
==========================================
- Coverage   62.18%   61.09%   -1.09%     
==========================================
  Files         281      290       +9     
  Lines       15111    15434     +323     
==========================================
+ Hits         9397     9430      +33     
- Misses       5271     5558     +287     
- Partials      443      446       +3

Impacted Files	Coverage Δ
api/schedule/delete.go	`0.00% <0.00%> (ø)`
api/schedule/get.go	`0.00% <0.00%> (ø)`
api/schedule/list.go	`0.00% <0.00%> (ø)`
api/schedule/update.go	`0.00% <0.00%> (ø)`
router/middleware/schedule/schedule.go	`0.00% <0.00%> (ø)`
api/schedule/create.go	`8.87% <8.87%> (ø)`
router/middleware/allowlist_schedule.go	`100.00% <100.00%> (ø)`
router/middleware/schedule/context.go	`100.00% <100.00%> (ø)`
router/middleware/schedule_frequency.go	`100.00% <100.00%> (ø)`

api/repo/create.go

api/schedule/create.go

mock/server/schedule.go

util/util.go

router/middleware/schedule/context.go

router/router.go

router/schedule.go

api/schedule/create.go

api/schedule/update.go

Co-authored-by: Jordan Brockopp <[email protected]>

api/schedule/create.go

api/schedule/update.go

cmd/vela-server/main.go

router/middleware/schedule/context_test.go

JordanSussman · 2023-05-19T15:23:49Z

@jbrockopp @ecrupper feedback has been addressed.

api/schedule/update.go

into feature/schedule/api

jbrockopp

LGTM

api/schedule/create.go

ecrupper · 2023-05-19T16:30:16Z

I also want to point out that I was kind of disappointed with github.com/adhocore/gronx error handling with invalid entries. For example, I provided an entry of 0 0 0 * *, which is invalid due to day_of_month being 0, but the error output was

{
	"error": "schedule of  is invalid: tried so hard"
}

I expect users to be able to diagnose an invalid cron expression, but "tried so hard" isn't exactly a great push in the right direction.

api/schedule/update.go

api/schedule/create.go

api/schedule/update.go

plyr4 · 2023-05-19T16:37:57Z

api/schedule/create.go

+		}
+
+		// send API call to capture the updated schedule
+		s, _ = database.FromContext(c).GetScheduleForRepo(r, dbSchedule.GetName())


im not sure why we ignore the return errors on so many database calls across the codebase.
(im not calling you out, im just curious if yall have thoughts)

we dont have to make this change now, but im wondering why we continue to follow that pattern?

I'll be honest that I didn't think about handling the error since so much of the existing code base does not... How about we open up a separate GitHub issue to track updating all of these database calls?

FWIW -

We should plan to have the Create* and Update* funcs return the type so we don't need these calls

i.e. #701

Whoever wrote that PR needs to get on it

ecrupper

Nice

jbrockopp and others added 21 commits February 14, 2023 14:00

Merge branch 'main' of github.com:go-vela/server

74626c9

Merge branch 'main' of github.com:go-vela/server

974c8e6

Merge branch 'main' of github.com:go-vela/server

2f2c425

Merge branch 'main' of github.com:go-vela/server

528291a

Merge branch 'main' of github.com:go-vela/server

b53c687

Merge branch 'main' of github.com:go-vela/server

4734dcb

Merge branch 'main' of github.com:go-vela/server

1fb52df

Merge branch 'main' of github.com:go-vela/server

e996aa6

feat(api/types): add support for schedules

6d250b0

feat(database/types): add support for schedules

661dca8

feat(database): add support for schedules

98b7565

chore: update go dependencies

737e5f8

Merge branch 'feature/schedule/types' of github.com:go-vela/server in…

5a045c2

…to feature/schedule/database

feat(database): add schedule engine

bd4c5d2

feat(api): add support for schedules

2e4ba0e

add routes

1b6be80

fix: parse entry for schedules

328afc0

Merge branch 'feature/schedule/types' of github.com:go-vela/server in…

4401490

…to feature/schedule/database

more wip code

8563be9

add schedule allowlist

abf5003

fix tests

02e636a

JordanSussman commented May 3, 2023

View reviewed changes

api/repo/create.go Show resolved Hide resolved

jbrockopp previously requested changes May 3, 2023

View reviewed changes

api/schedule/create.go Outdated Show resolved Hide resolved

JordanSussman added 4 commits May 3, 2023 14:53

add validation for entry

fe77a28

add mocks w/o updated payloads

84769fc

fix issues with create

443dc69

update mock responses

2b908d7

github-actions bot reviewed May 3, 2023

View reviewed changes

use schedule mocks

2295ed0

jbrockopp requested changes May 19, 2023

View reviewed changes

JordanSussman and others added 6 commits May 19, 2023 09:23

Update api/schedule/create.go

3af214b

Co-authored-by: Jordan Brockopp <[email protected]>

Update api/schedule/create.go

ba55598

Co-authored-by: Jordan Brockopp <[email protected]>

Update api/schedule/create.go

0866368

Co-authored-by: Jordan Brockopp <[email protected]>

Update api/schedule/create.go

593f119

Co-authored-by: Jordan Brockopp <[email protected]>

Update api/schedule/create.go

6cc6b66

Co-authored-by: Jordan Brockopp <[email protected]>

Update api/schedule/create.go

20d5de7

Co-authored-by: Jordan Brockopp <[email protected]>

ecrupper requested changes May 19, 2023

View reviewed changes

JordanSussman added 2 commits May 19, 2023 10:21

address feedback

cbadf8d

Merge branch 'main' into feature/schedule/api

0ea97a7

github-actions bot reviewed May 19, 2023

View reviewed changes

api/schedule/update.go Outdated Show resolved Hide resolved

JordanSussman added 2 commits May 19, 2023 10:25

goimports

643fa88

Merge branch 'feature/schedule/api' of https://github.com/go-vela/server

2eddb67

into feature/schedule/api

jbrockopp previously approved these changes May 19, 2023

View reviewed changes

ecrupper requested changes May 19, 2023

View reviewed changes

api/schedule/create.go Outdated Show resolved Hide resolved

ecrupper requested changes May 19, 2023

View reviewed changes

api/schedule/update.go Outdated Show resolved Hide resolved

api/schedule/create.go Outdated Show resolved Hide resolved

plyr4 reviewed May 19, 2023

View reviewed changes

address feedback

d3b99a2

JordanSussman dismissed jbrockopp’s stale review via d3b99a2 May 19, 2023 18:35

JordanSussman added 3 commits May 19, 2023 13:44

Merge branch 'main' into feature/schedule/api

cde7bc0

updated logic for updating inactive schedules

790b79c

clarify error message

d601eba

ecrupper approved these changes May 19, 2023

View reviewed changes

plyr4 approved these changes May 19, 2023

View reviewed changes

ecrupper merged commit f276fee into main May 19, 2023

ecrupper deleted the feature/schedule/api branch May 19, 2023 21:07

jbrockopp mentioned this pull request May 23, 2023

feat: add support for schedules go-vela/worker#479

Merged

colindean mentioned this pull request Aug 28, 2023

Increase Starlark execution limit, abstract limit resolver colindean/server#1

Closed

feat(api): add support for schedules #836

feat(api): add support for schedules #836

Uh oh!

Conversation

JordanSussman commented May 3, 2023 • edited by jbrockopp Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented May 3, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JordanSussman commented May 19, 2023

Uh oh!

Uh oh!

jbrockopp left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ecrupper commented May 19, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

plyr4 May 19, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JordanSussman May 19, 2023

Choose a reason for hiding this comment

Uh oh!

jbrockopp May 19, 2023

Choose a reason for hiding this comment

Uh oh!

ecrupper May 19, 2023

Choose a reason for hiding this comment

Uh oh!

ecrupper left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

JordanSussman commented May 3, 2023 •

edited by jbrockopp

Loading

codecov bot commented May 3, 2023 •

edited

Loading

plyr4 May 19, 2023 •

edited

Loading