fix(webhook): more general error message for redelivery failure #707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wass3r
approved these changes
Sep 29, 2022
Codecov Report
@@ Coverage Diff @@
## main #707 +/- ##
=======================================
Coverage 54.98% 54.98%
=======================================
Files 211 211
Lines 16014 16014
=======================================
Hits 8805 8805
Misses 6831 6831
Partials 378 378
|
plyr4
approved these changes
Sep 29, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes the webhook delivery will no longer be available due to how old it is, not whether it is in the 100 most recent. Upon failure, it's a better idea to give a general error to avoid confusing the user.