Skip to content

fix(webhook): more general error message for redelivery failure #707

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecrupper merged 1 commit into from
Sep 29, 2022
Merged

fix(webhook): more general error message for redelivery failure #707

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scm/github/webhook.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -502,7 +502,7 @@ func (c *client) getDeliveryID(ctx context.Context, ghClient *github.Client, r *
}

// if not found, webhook was not recent enough for GitHub
err = fmt.Errorf("webhook not one of the 100 most recent deliveries")
err = fmt.Errorf("webhook no longer available to be redelivered")

return 0, err
}