Skip to content

refactor(api): move repo logic to separate package #754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ecrupper merged 12 commits into from
Mar 21, 2023
Merged

refactor(api): move repo logic to separate package #754

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d3234cc
refactor(api): move repo handlers to new package
jbrockopp Jan 6, 2023
27fb80a
Merge branch 'main' of github.com:go-vela/server into refactor/api/repo
jbrockopp Mar 4, 2023
e1f041e
enhance(perm): skip access checks for personal org
jbrockopp Mar 4, 2023
2b7e70a
chore: changes from merge conflict
jbrockopp Mar 4, 2023
80c0f55
chore: address linter feedback
jbrockopp Mar 4, 2023
6d1ed5b
fix: failing tests for perms
jbrockopp Mar 4, 2023
99e177a
chore: address review feedback
jbrockopp Mar 9, 2023
b31d61d
Merge branch 'main' into refactor/api/repo
jbrockopp Mar 9, 2023
7bc0df1
chore: address review feedback
jbrockopp Mar 16, 2023
cd47c58
Merge branch 'refactor/api/repo' of github.com:go-vela/server into re…
jbrockopp Mar 16, 2023
97b5842
Merge branch 'main' into refactor/api/repo
jbrockopp Mar 16, 2023
7f427d0
Merge branch 'main' into refactor/api/repo
ecrupper Mar 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix: failing tests for perms
  • Loading branch information
@jbrockopp
jbrockopp committed Mar 4, 2023
commit 6d1ed5b78c7acacc1461c413c687b74ec5cd6d29
32 changes: 16 additions & 16 deletions router/middleware/perm/perm_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ func TestPerm_MustPlatformAdmin(t *testing.T) {

u := new(library.User)
u.SetID(1)
u.SetName("foo")
u.SetName("foob")
u.SetToken("bar")
u.SetHash("baz")
u.SetAdmin(true)
Expand Down Expand Up @@ -121,7 +121,7 @@ func TestPerm_MustPlatformAdmin_NotAdmin(t *testing.T) {

u := new(library.User)
u.SetID(1)
u.SetName("foo")
u.SetName("foob")
u.SetToken("bar")
u.SetHash("baz")
u.SetAdmin(false)
Expand Down Expand Up @@ -877,7 +877,7 @@ func TestPerm_MustAdmin(t *testing.T) {

u := new(library.User)
u.SetID(1)
u.SetName("foo")
u.SetName("foob")
u.SetToken("bar")
u.SetHash("baz")
u.SetAdmin(false)
Expand Down Expand Up @@ -973,7 +973,7 @@ func TestPerm_MustAdmin_PlatAdmin(t *testing.T) {

u := new(library.User)
u.SetID(1)
u.SetName("foo")
u.SetName("foob")
u.SetToken("bar")
u.SetHash("baz")
u.SetAdmin(true)
Expand Down Expand Up @@ -1069,7 +1069,7 @@ func TestPerm_MustAdmin_NotAdmin(t *testing.T) {

u := new(library.User)
u.SetID(1)
u.SetName("foo")
u.SetName("foob")
u.SetToken("bar")
u.SetHash("baz")
u.SetAdmin(false)
Expand Down Expand Up @@ -1165,7 +1165,7 @@ func TestPerm_MustWrite(t *testing.T) {

u := new(library.User)
u.SetID(1)
u.SetName("foo")
u.SetName("foob")
u.SetToken("bar")
u.SetHash("baz")
u.SetAdmin(false)
Expand Down Expand Up @@ -1261,7 +1261,7 @@ func TestPerm_MustWrite_PlatAdmin(t *testing.T) {

u := new(library.User)
u.SetID(1)
u.SetName("foo")
u.SetName("foob")
u.SetToken("bar")
u.SetHash("baz")
u.SetAdmin(true)
Expand Down Expand Up @@ -1357,7 +1357,7 @@ func TestPerm_MustWrite_RepoAdmin(t *testing.T) {

u := new(library.User)
u.SetID(1)
u.SetName("foo")
u.SetName("foob")
u.SetToken("bar")
u.SetHash("baz")
u.SetAdmin(false)
Expand Down Expand Up @@ -1453,7 +1453,7 @@ func TestPerm_MustWrite_NotWrite(t *testing.T) {

u := new(library.User)
u.SetID(1)
u.SetName("foo")
u.SetName("foob")
u.SetToken("bar")
u.SetHash("baz")
u.SetAdmin(false)
Expand Down Expand Up @@ -1549,7 +1549,7 @@ func TestPerm_MustRead(t *testing.T) {

u := new(library.User)
u.SetID(1)
u.SetName("foo")
u.SetName("foob")
u.SetToken("bar")
u.SetHash("baz")
u.SetAdmin(false)
Expand Down Expand Up @@ -1645,7 +1645,7 @@ func TestPerm_MustRead_PlatAdmin(t *testing.T) {

u := new(library.User)
u.SetID(1)
u.SetName("foo")
u.SetName("foob")
u.SetToken("bar")
u.SetHash("baz")
u.SetAdmin(true)
Expand Down Expand Up @@ -1823,7 +1823,7 @@ func TestPerm_MustRead_RepoAdmin(t *testing.T) {

u := new(library.User)
u.SetID(1)
u.SetName("foo")
u.SetName("foob")
u.SetToken("bar")
u.SetHash("baz")
u.SetAdmin(false)
Expand Down Expand Up @@ -1919,7 +1919,7 @@ func TestPerm_MustRead_RepoWrite(t *testing.T) {

u := new(library.User)
u.SetID(1)
u.SetName("foo")
u.SetName("foob")
u.SetToken("bar")
u.SetHash("baz")
u.SetAdmin(false)
Expand Down Expand Up @@ -2015,7 +2015,7 @@ func TestPerm_MustRead_RepoPublic(t *testing.T) {

u := new(library.User)
u.SetID(1)
u.SetName("foo")
u.SetName("foob")
u.SetToken("bar")
u.SetHash("baz")
u.SetAdmin(false)
Expand Down Expand Up @@ -2111,7 +2111,7 @@ func TestPerm_MustRead_NotRead(t *testing.T) {

u := new(library.User)
u.SetID(1)
u.SetName("foo")
u.SetName("foob")
u.SetToken("bar")
u.SetHash("baz")
u.SetAdmin(false)
Expand Down Expand Up @@ -2291,7 +2291,7 @@ const permNonePayload = `

const userPayload = `
{
"login": "foo",
"login": "foob",
"id": 1,
"node_id": "MDQ6VXNlcjE=",
"avatar_url": "https://github.com/images/error/octocat_happy.gif",
Expand Down