-
Notifications
You must be signed in to change notification settings - Fork 30
refactor(api): move repo logic to separate package #754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## main #754 +/- ##
==========================================
+ Coverage 54.87% 56.89% +2.02%
==========================================
Files 244 243 -1
Lines 16506 15939 -567
==========================================
+ Hits 9058 9069 +11
+ Misses 7048 6468 -580
- Partials 400 402 +2
|
cognifloyd
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor nit, but looks good to me anyway. It's nice to see all of this moving into separate modules with shorter files. So much nicer.
ecrupper
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple questions out of curiosity, but otherwise LGTM — I like the refactor
|
@cognifloyd @ecrupper ready for review again 👍 |
Based off of #615
This change continues the refactor efforts initially introduced in the above PR.
This adds a new
repopackage to thegithub.amrom.workers.dev/go-vela/server/apipackage.This contains all the same handlers that existed previously but with each of them within their own file.
Also, this change skips checking a user's access for orgs, repos, and teams if that resource is in their personal org.
i.e. Vela no longer check's my access level for those resources when interacting with https://github.com/jbrockopp
This will help improve the user experience when developing locally and reduce unneeded calls to the SCM.