Skip to content

Conversation

@JordanSussman
Copy link
Collaborator

@JordanSussman JordanSussman commented Jan 30, 2023

closes go-vela/community#745

Note: this change will not have an impact on activations from the UI until go-vela/ui#621 has been merged.

@codecov
Copy link

codecov bot commented Jan 30, 2023

Codecov Report

Merging #758 (c279aaa) into main (f76146b) will decrease coverage by 0.03%.
The diff coverage is 27.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #758      +/-   ##
==========================================
- Coverage   54.40%   54.38%   -0.03%     
==========================================
  Files         224      225       +1     
  Lines       16168    16184      +16     
==========================================
+ Hits         8797     8802       +5     
- Misses       6978     6989      +11     
  Partials      393      393              
Impacted Files Coverage Δ
api/repo.go 0.00% <0.00%> (ø)
router/middleware/default_repo_events.go 100.00% <100.00%> (ø)

@JordanSussman JordanSussman marked this pull request as ready for review January 30, 2023 16:11
@JordanSussman JordanSussman requested a review from a team as a code owner January 30, 2023 16:11
Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@wass3r wass3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks.. would like a draft PR to /docs for this change as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Customizable events for newly activated repositories

5 participants