enhance: switch to adhocore/gronx

database/types/schedule.go

@@ -8,9 +8,9 @@ import (
 	"database/sql"
 	"errors"
 
+	"github.com/adhocore/gronx"
 	"github.com/go-vela/server/api/types"
 	"github.com/go-vela/types/library"
-	"github.com/robfig/cron/v3"
 )
 
 var (
@@ -25,9 +25,6 @@ var (
 
 	// ErrInvalidScheduleEntry defines the error type when a Schedule type has an invalid Entry field provided.
 	ErrInvalidScheduleEntry = errors.New("invalid schedule entry provided")
-
-	// scheduleParser defines the parser used for validating the Entry field for the Schedule type.
-	scheduleParser = cron.NewParser(cron.Minute | cron.Hour | cron.Dom | cron.Month | cron.Dow)
 )
 
 // Schedule is the database representation of a schedule for a repo.
@@ -128,8 +125,8 @@ func (s *Schedule) Validate() error {
 		return ErrEmptyScheduleEntry
 	}
 
-	_, err := scheduleParser.Parse(s.Entry.String)
-	if err != nil {
+	gron := gronx.New()
+	if !gron.IsValid(s.Entry.String) {
 		return ErrInvalidScheduleEntry
 	}
 

go.mod

@@ -7,6 +7,7 @@ require (
 	github.com/DATA-DOG/go-sqlmock v1.5.0
 	github.com/Masterminds/semver/v3 v3.2.1
 	github.com/Masterminds/sprig/v3 v3.2.3
+	github.com/adhocore/gronx v1.6.2
 	github.com/alicebob/miniredis/v2 v2.30.2
 	github.com/aws/aws-sdk-go v1.44.248
 	github.com/buildkite/yaml v0.0.0-20181016232759-0caa5f0796e3

go.sum

@@ -57,6 +57,8 @@ github.com/PuerkitoBio/purell v1.1.1 h1:WEQqlqaGbrPkxLJWfBwQmfEAE1Z7ONdDLqrN38tN
 github.com/PuerkitoBio/purell v1.1.1/go.mod h1:c11w/QuzBsJSee3cPx9rAFu61PvFxuPbtSwDGJws/X0=
 github.com/PuerkitoBio/urlesc v0.0.0-20170810143723-de5bf2ad4578 h1:d+Bc7a5rLufV/sSk/8dngufqelfh6jnri85riMAaF/M=
 github.com/PuerkitoBio/urlesc v0.0.0-20170810143723-de5bf2ad4578/go.mod h1:uGdkoq3SwY9Y+13GIhn11/XLaGBb4BfwItxLd5jeuXE=
+github.com/adhocore/gronx v1.6.2 h1:/Pg6cuHFJmUGRIYWhRFjb6iL9fdzNmoMPj+/r6L01KU=
+github.com/adhocore/gronx v1.6.2/go.mod h1:7oUY1WAU8rEJWmAxXR2DN0JaO4gi9khSgKjiRypqteg=
 github.com/alicebob/gopher-json v0.0.0-20180125190556-5a6b3ba71ee6/go.mod h1:SGnFV6hVsYE877CKEZ6tDNTjaSXYUk6QqoIK6PrAtcc=
 github.com/alicebob/gopher-json v0.0.0-20200520072559-a9ecdc9d1d3a h1:HbKu58rmZpUGpz5+4FfNmIU+FmZg2P3Xaj2v2bfNWmk=
 github.com/alicebob/gopher-json v0.0.0-20200520072559-a9ecdc9d1d3a/go.mod h1:SGnFV6hVsYE877CKEZ6tDNTjaSXYUk6QqoIK6PrAtcc=