Skip to content

Conversation

@jbrockopp
Copy link
Contributor

@jbrockopp jbrockopp commented May 17, 2023

xref: go-vela/community#538

Part of go-vela/community#772

Dependent on #836

This adds support for Vela to interact with schedules created in the database and spawn builds accordingly.

NOTE: In order to run a pipeline with support for schedules, you'll need go-vela/worker#479.

jbrockopp and others added 30 commits February 14, 2023 14:00
@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #846 (536c7f5) into main (ffac676) will increase coverage by 0.01%.
The diff coverage is 48.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #846      +/-   ##
==========================================
+ Coverage   66.78%   66.79%   +0.01%     
==========================================
  Files         283      283              
  Lines       14129    14144      +15     
==========================================
+ Hits         9436     9448      +12     
- Misses       4247     4249       +2     
- Partials      446      447       +1     
Impacted Files Coverage Δ
api/schedule/create.go 8.87% <ø> (ø)
api/schedule/delete.go 0.00% <ø> (ø)
api/schedule/get.go 0.00% <ø> (ø)
api/schedule/list.go 0.00% <ø> (ø)
api/schedule/update.go 0.00% <ø> (ø)
api/webhook.go 0.00% <0.00%> (ø)
api/build.go 1.34% <12.50%> (ø)
scm/github/repo.go 76.61% <80.00%> (+0.12%) ⬆️

@jbrockopp jbrockopp marked this pull request as ready for review May 22, 2023 20:20
@jbrockopp jbrockopp requested a review from a team as a code owner May 22, 2023 20:20
Copy link
Member

@wass3rw3rk wass3rw3rk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

couple of comments for now, but looks good overall - thanks for the work!

and a note for @ecrupper to make sure it plays nicely with #859

@jbrockopp
Copy link
Contributor Author

couple of comments for now, but looks good overall - thanks for the work!

and a note for @ecrupper to make sure it plays nicely with #859

Apologies as I missed that PR 😅 I've updated this PR to also use compiler.WithCommit().

Please let me know if you have any additional feedback or there is anything else I'm missing 👍

Copy link
Contributor

@ecrupper ecrupper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like it a lot. Small thing I noticed but that's it 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature Indicates a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants