fix(compiler): add commit field to compiler engine to handle file type template lite compilation #859
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using any compiler function which does not involve instantiating the compiler with a build (
compiler.FromContext(c).WithBuild(b)), any time a lite compilation is requested (many pipeline API endpoints), the compiler fails to grab the correct template from the SCM due to this line. This change addresses the bug by adding acommitfield to the compiler engine, which felt like the least invasive way of holding the commit SHA during compilation / template fetching. Open to other ideas as well.Steps to recreate bug if interested:
filetype on the default branch of a repository{{ base_url }}/api/v1/pipelines/{{ org }}/{{ repo }}/{{ pipeline }}/expandwill show you the expanded version as pulling in the template version from the default branch.