refactor(db): return hook created or updated #861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #861 +/- ##
==========================================
+ Coverage 66.12% 66.13% +0.01%
==========================================
Files 297 297
Lines 13879 13876 -3
==========================================
Hits 9177 9177
+ Misses 4255 4252 -3
Partials 447 447
|
cognifloyd
approved these changes
May 26, 2023
Member
cognifloyd
left a comment
cognifloyd
left a comment
There was a problem hiding this comment.
Straight forward improvement
This was referenced Jun 12, 2023
This was referenced Jul 18, 2023
This was referenced Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor is an effort to eliminate several
Getrequests to the DB immediately after creating or updating a resource. Fortunately, with Gorm's create and save methods, the object is populated with any fields that are generated upon DB insertion (ID namely). In other words, we can safely return the object we use for these operations.