Skip to content

Conversation

@JordanSussman
Copy link
Collaborator

@JordanSussman JordanSussman commented Jun 29, 2023

Add context.Context as the first argument to every schedule function.

xref: go-vela/community#832

@codecov
Copy link

codecov bot commented Jun 29, 2023

Codecov Report

Merging #898 (a1339bb) into main (b3084f9) will decrease coverage by 0.05%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #898      +/-   ##
==========================================
- Coverage   71.46%   71.42%   -0.05%     
==========================================
  Files         304      304              
  Lines       12463    12482      +19     
==========================================
+ Hits         8907     8915       +8     
- Misses       3121     3132      +11     
  Partials      435      435              
Files Changed Coverage Δ
api/schedule/create.go 14.28% <0.00%> (-0.11%) ⬇️
api/schedule/delete.go 0.00% <0.00%> (ø)
api/schedule/list.go 0.00% <0.00%> (ø)
api/schedule/update.go 0.00% <0.00%> (ø)
database/opts.go 90.32% <0.00%> (-9.68%) ⬇️
router/middleware/schedule/schedule.go 0.00% <0.00%> (ø)
database/database.go 63.38% <100.00%> (+0.52%) ⬆️
database/resource.go 69.69% <100.00%> (+0.30%) ⬆️
database/schedule/count.go 100.00% <100.00%> (ø)
database/schedule/count_active.go 100.00% <100.00%> (ø)
... and 13 more

@JordanSussman JordanSussman marked this pull request as ready for review August 2, 2023 18:35
@JordanSussman JordanSussman requested a review from a team as a code owner August 2, 2023 18:35
Copy link
Contributor

@plyr4 plyr4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, ty.
might want to add a story to revisit the context.TODO()s later, but its a great start.

@JordanSussman
Copy link
Collaborator Author

might want to add a story to revisit the context.TODO()s later, but its a great start.

Do you think we should include that work now? Removing the context.TODOs will require us to touch the api/router codebase to pass along the gin context.

@plyr4
Copy link
Contributor

plyr4 commented Aug 2, 2023

Do you think we should include that work now? Removing the context.TODOs will require us to touch the api/router codebase to pass along the gin context.

may as well, I suppose

Copy link
Contributor

@jbrockopp jbrockopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plyr4
Copy link
Contributor

plyr4 commented Aug 3, 2023

@JordanSussman im fine merging as-is, just let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants