Skip to content

Conversation

@plyr4
Copy link
Contributor

@plyr4 plyr4 commented Sep 1, 2023

continuing the efforts started in #898 #922 #923 #930 #937 #938 #941 #942

this is prep to add support for OpenTelemetry tracing.

the reason being, otel can (for the most part) work out of the box if you pass around contexts properly.

@plyr4 plyr4 requested a review from a team as a code owner September 1, 2023 14:20
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #950 (fc70cd1) into main (987704f) will increase coverage by 0.01%.
The diff coverage is 95.83%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #950      +/-   ##
==========================================
+ Coverage   70.94%   70.95%   +0.01%     
==========================================
  Files         311      311              
  Lines       12902    12909       +7     
==========================================
+ Hits         9153     9160       +7     
  Misses       3284     3284              
  Partials      465      465              
Files Changed Coverage Δ
api/build/plan.go 0.00% <0.00%> (ø)
database/log/count.go 100.00% <100.00%> (ø)
database/log/count_build.go 100.00% <100.00%> (ø)
database/log/create.go 66.66% <100.00%> (ø)
database/log/delete.go 85.71% <100.00%> (ø)
database/log/get.go 88.46% <100.00%> (ø)
database/log/get_service.go 88.46% <100.00%> (ø)
database/log/get_step.go 88.46% <100.00%> (ø)
database/log/index.go 100.00% <100.00%> (ø)
database/log/list.go 76.92% <100.00%> (ø)
... and 6 more

Copy link
Contributor

@KellyMerrick KellyMerrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@plyr4 plyr4 merged commit 9742e3d into main Sep 1, 2023
@plyr4 plyr4 deleted the enhance/ctx-log branch September 1, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants