Skip to content

execabs: isGo119ErrDot: use errors.Is instead of string-matching #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
thaJeztah wants to merge 1 commit into from
Closed

execabs: isGo119ErrDot: use errors.Is instead of string-matching #142

thaJeztah wants to merge 1 commit into from

Conversation

@thaJeztah
Copy link
Contributor

@thaJeztah thaJeztah commented Nov 9, 2022 •
edited
Loading

Addresses the TODO added in CL 403256.

@gopherbot
Copy link
Contributor

gopherbot commented Nov 9, 2022

This PR (HEAD: d72f1b8) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/448877 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Nov 9, 2022

Message from Ian Lance Taylor:

Patch Set 1: Run-TryBot+1

Please don’t reply on this GitHub thread. Visit golang.org/cl/448877.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 9, 2022

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448877.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 9, 2022

Message from Gopher Robot:

Patch Set 1: TryBot-Result+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448877.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 10, 2022

Message from Ian Lance Taylor:

Patch Set 1:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448877.
After addressing review feedback, remember to publish your drafts!

@thaJeztah thaJeztah force-pushed the execabs_no_string_matching branch from d72f1b8 to 99ba4c2 Compare November 10, 2022 09:16
@gopherbot
Copy link
Contributor

gopherbot commented Nov 10, 2022

This PR (HEAD: 99ba4c2) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/448877 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Nov 10, 2022

Message from Sebastiaan van Stijn:

Patch Set 2:

(3 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448877.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 10, 2022

Message from Ian Lance Taylor:

Patch Set 2: Run-TryBot+1

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448877.
After addressing review feedback, remember to publish your drafts!

@thaJeztah thaJeztah changed the title execabs: isGo119ErrDot(): use errors.Is() instead of string-matching execabs: isGo119ErrDot: use errors.Is instead of string-matching Nov 10, 2022
@thaJeztah
execabs: isGo119ErrDot: use errors.Is instead of string-matching
1adfdb7 
Addresses the TODO added in CL 403256.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah force-pushed the execabs_no_string_matching branch from 99ba4c2 to 1adfdb7 Compare November 10, 2022 18:56
@gopherbot
Copy link
Contributor

gopherbot commented Nov 10, 2022

This PR (HEAD: 1adfdb7) has been imported to Gerrit for code review.

Please visit https://go-review.googlesource.com/c/sys/+/448877 to see it.

Tip: You can toggle comments from me using the comments slash command (e.g. /comments off)
See the Wiki page for more info

@gopherbot
Copy link
Contributor

gopherbot commented Nov 10, 2022

Message from Sebastiaan van Stijn:

Patch Set 2:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448877.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 10, 2022

Message from Sebastiaan van Stijn:

Patch Set 3:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448877.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link
Contributor

gopherbot commented Nov 10, 2022

Message from Ian Lance Taylor:

Patch Set 3: Run-TryBot+1 Auto-Submit+1 Code-Review+2

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/448877.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Nov 10, 2022
@thaJeztah @gopherbot
execabs: isGo119ErrDot: use errors.Is instead of string-matching
d684c6f 
Addresses the TODO added in CL 403256.

Change-Id: Iae44242e00b6a309cc0f1e336462bc2d4995a5e2
GitHub-Last-Rev: 1adfdb7
GitHub-Pull-Request: #142
Reviewed-on: https://go-review.googlesource.com/c/sys/+/448877
Auto-Submit: Ian Lance Taylor <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
Reviewed-by: Michael Knyszek <[email protected]>
Run-TryBot: Ian Lance Taylor <[email protected]>
TryBot-Result: Gopher Robot <[email protected]>
Reviewed-by: Ian Lance Taylor <[email protected]>
@gopherbot
Copy link
Contributor

gopherbot commented Nov 10, 2022

This PR is being closed because golang.org/cl/448877 has been merged.

@gopherbot gopherbot closed this Nov 10, 2022
@thaJeztah thaJeztah deleted the execabs_no_string_matching branch November 10, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thaJeztah @gopherbot