Skip to content

execabs: isGo119ErrDot: use errors.Is instead of string-matching #142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thaJeztah wants to merge 1 commit into from
Closed

execabs: isGo119ErrDot: use errors.Is instead of string-matching #142

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
execabs: isGo119ErrDot: use errors.Is instead of string-matching 
Addresses the TODO added in CL 403256.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
  • Loading branch information
@thaJeztah
thaJeztah committed Nov 10, 2022
commit 1adfdb799489c068127e5088cd131dcca79d86df
8 changes: 5 additions & 3 deletions execabs/execabs_go119.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@

package execabs

import "strings"
import (
"errors"
"os/exec"
)

func isGo119ErrDot(err error) bool {
// TODO: return errors.Is(err, exec.ErrDot)
return strings.Contains(err.Error(), "current directory")
return errors.Is(err, exec.ErrDot)
}