Skip to content
This repository was archived by the owner on Oct 13, 2025. It is now read-only.
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Refactor visibility_detector to avoid forcing compositing.
Instead, use methods on RenderObject and new framework API to
listen to compositing and determine the transform/clip.

Removes an O(N^2) algorithm from the ancestor walk.

Deletes the custom layer that is no longer used.

Minor update to main.dart to be more desktop friendly.

Tests adjusted to use new API. Removed API has no usages
in internal codesearch.
  • Loading branch information
dnfield committed May 10, 2022
commit 6688c842d1280f3f3e14cd9073ed175e7ac21066
1 change: 1 addition & 0 deletions packages/visibility_detector/example/lib/main.dart
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@ class VisibilityDetectorDemo extends StatelessWidget {
Widget build(BuildContext context) {
return MaterialApp(
title: title,
scrollBehavior: const MaterialScrollBehavior().copyWith(scrollbars: false),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this related?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes the framework stop complaining when you run the example app in desktop mode. It's not essential for this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(No, it's not related)

theme: ThemeData(primarySwatch: Colors.blue),
home: VisibilityDetectorDemoPage(key: key, useSlivers: useSlivers),
);
Expand Down

This file was deleted.

Loading