Skip to content
This repository was archived by the owner on Oct 13, 2025. It is now read-only.

Refactor visibility_detector to avoid forcing compositing. #367

Merged
xster merged 19 commits into from
May 24, 2022
Merged

Refactor visibility_detector to avoid forcing compositing. #367

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
6688c84
Refactor visibility_detector to avoid forcing compositing.
dnfield May 10, 2022
a81e311
Delay visibility determination
dnfield May 11, 2022
7d21eaa
fixes
dnfield May 11, 2022
4abf7ca
pub/changelog
dnfield May 11, 2022
c45a66a
merge
dnfield May 11, 2022
9cbdb1b
..
dnfield May 11, 2022
d002ed3
EXPANDO!
dnfield May 11, 2022
13c3bde
one more
dnfield May 11, 2022
b5e43fd
more tests, remove caching
dnfield May 14, 2022
88f2b70
update to match landed API
dnfield May 18, 2022
d88c017
Fix ordering of clip transform, add test
dnfield May 24, 2022
9ac9fbe
Update packages/visibility_detector/lib/src/render_visibility_detecto…
dnfield May 24, 2022
eeb4d13
goderbauer review
dnfield May 24, 2022
4491555
Merge branch 'ro' of github.com:dnfield/flutter.widgets into ro
dnfield May 24, 2022
76f825b
remove screenRect, fix initialization bug
dnfield May 24, 2022
af74e16
more
dnfield May 24, 2022
1ba8777
CI
dnfield May 24, 2022
1058986
Revert "CI"
dnfield May 24, 2022
16f1ee1
format
dnfield May 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update to match landed API
  • Loading branch information
@dnfield
dnfield committed May 18, 2022
commit 88f2b70028c0b8b92f5545102300d151af801b9d
12 changes: 8 additions & 4 deletions packages/visibility_detector/lib/src/render_visibility_detector.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,9 +246,11 @@ class RenderVisibilityDetector extends RenderProxyBox
if (onVisibilityChanged != null) {
Copy link
Member

@goderbauer goderbauer May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like paint here and in RenderSliverVisibilityDetector have a lot in common, the inly difference is the second argument passed to _scheduleUpdate? Maybe move paint to the base and have this class and RenderSliverVisibilityDetector implement just a method that returns the value for that second argument?

Copy link
Contributor Author

@dnfield dnfield May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

Copy link
Contributor Author

@dnfield dnfield May 24, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, as mentioned elsehwere moved this to a Rect get bounds; on the mixin, which simplified things a bit.

_compositionCallbackCanceller?.call();
_compositionCallbackCanceller =
context.addCompositionCallback((ContainerLayer layer) {
context.addCompositionCallback((Layer layer) {
assert(!debugDisposed!);
_scheduleUpdate(layer, offset & semanticBounds.size);
final ContainerLayer? container =
layer is ContainerLayer ? layer : layer.parent;
_scheduleUpdate(container, offset & semanticBounds.size);
});
}
super.paint(context, offset);
Expand Down Expand Up @@ -279,7 +281,7 @@ class RenderSliverVisibilityDetector extends RenderProxySliver
if (onVisibilityChanged != null) {
_compositionCallbackCanceller?.call();
_compositionCallbackCanceller =
context.addCompositionCallback((ContainerLayer layer) {
context.addCompositionCallback((Layer layer) {
assert(!debugDisposed!);

Size widgetSize;
Expand Down Expand Up @@ -315,7 +317,9 @@ class RenderSliverVisibilityDetector extends RenderProxySliver
Size(geometry!.scrollExtent, constraints.crossAxisExtent);
break;
}
_scheduleUpdate(layer, offset + widgetOffset & widgetSize);
final ContainerLayer? container =
layer is ContainerLayer ? layer : layer.parent;
_scheduleUpdate(container, offset + widgetOffset & widgetSize);
});
}
super.paint(context, offset);
Expand Down