Skip to content

Adds AdSense support #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jonkeller merged 10 commits into from
Sep 6, 2019
Merged

Adds AdSense support #119

jonkeller merged 10 commits into from
Sep 6, 2019

Conversation

@jonkeller
Copy link
Collaborator

@jonkeller jonkeller commented Sep 4, 2019 •
edited
Loading

Adds AdSense support to most relevant audits. First Ad Paint support for AdSense will come in a separate PR, after both this one and #121 go in.

@jonkeller jonkeller self-assigned this Sep 4, 2019
jonkeller
jonkeller commented Sep 4, 2019
View reviewed changes
jburger424
jburger424 requested changes Sep 4, 2019
View reviewed changes
@jonkeller jonkeller requested a review from jburger424 September 4, 2019 17:37
warrengm
warrengm requested changes Sep 4, 2019
View reviewed changes
jonkeller
jonkeller commented Sep 5, 2019
View reviewed changes
jonkeller
jonkeller commented Sep 5, 2019
View reviewed changes
@jonkeller jonkeller requested a review from warrengm September 5, 2019 18:15
@jonkeller
Copy link
Collaborator Author

jonkeller commented Sep 5, 2019 •
edited
Loading

Current state:

  • Latency of first ad render - this audit is still GPT-only, but should be modified to work with AdSense in a separate PR
  • GPT and bids loaded in parallel, and
  • Header bidding is parallelized - header bidding is not relevant to AdSense, so these two audits haven't/won't be updated
  • GPT tag is loaded from recommended host - this is also not relevant to AdSense, as it has not recently launched any new hostname.

The remaining audits now run correctly for AdSense AFAICT.

warrengm
warrengm approved these changes Sep 6, 2019
View reviewed changes
@jonkeller jonkeller merged commit 62dd346 into master Sep 6, 2019
@jonkeller jonkeller deleted the asi-adsense branch September 6, 2019 18:37
@jonkeller
Copy link
Collaborator Author

jonkeller commented Sep 6, 2019

Fixes #2, with the exception of the First Ad Paint audit.

@jonkeller jonkeller mentioned this pull request Sep 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jburger424 jburger424 jburger424 approved these changes

@warrengm warrengm warrengm approved these changes

Assignees

@jonkeller jonkeller

Labels

AdSense audit

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jonkeller @jburger424 @warrengm